Skip to content

Avoid out-of-bounds section_starts_ read on invalid reloc index #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Jun 24, 2026
+5 −3
Merged

Avoid out-of-bounds section_starts_ read on invalid reloc index #2777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/binary-reader-objdump.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2161,7 +2161,7 @@ Result BinaryReaderObjdump::OnDylinkNeeded(std::string_view so_name) {
}

Result BinaryReaderObjdump::OnRelocCount(Index count, Index section_index) {
BinaryReaderObjdumpBase::OnRelocCount(count, section_index);
CHECK_RESULT(BinaryReaderObjdumpBase::OnRelocCount(count, section_index));
PrintDetails(" - relocations for section: %d (" PRIstringview ") [%d]\n",
section_index,
WABT_PRINTF_STRING_VIEW_ARG(GetSectionName(section_index)),
Expand Down
6 changes: 4 additions & 2 deletions test/binary/bad-relocs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@ magic
version
section("reloc.BAD") {
reloc_section[99]
reloc_count[0]
reloc_count[1]
reloc_type[0] ;; R_WASM_FUNCTION_INDEX_LEB
offset[0]
index[0]
}
(;; STDERR ;;;
invalid relocation section index: 99
Expand All @@ -20,7 +23,6 @@ Section Details:

Custom:
- name: "reloc.BAD"
- relocations for section: 99 () [0]

Code Disassembly:

Expand Down
Loading