Skip to content

[NFC] Document reference construction in closed world #8761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
May 22, 2026
+2 −2
Merged

[NFC] Document reference construction in closed world #8761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pass.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ struct PassOptions {
// Assume code outside of the module does not inspect or interact with GC and
// function references, with the goal of being able to aggressively optimize
// all user-defined types. The outside may hold on to references and pass them
// back in, but may not inspect their contents, call them, or reflect on their
// types in any way.
// back in, but may not inspect their contents, call them, construct them, or
Copy link
Copy Markdown
Member

@stevenfontanella stevenfontanella May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remembered we should probably update the CLI help as well?

binaryen/src/tools/tool-options.h

Lines 169 to 172 in 17d9262

"Assume code outside of the module does not inspect or interact with "
"GC and function references, even if they are passed out. The outside "
"may hold on to them and pass them back in, but not inspect their "
"contents or call them.",

Copy link
Copy Markdown
Member Author

@kripken kripken May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, but the CLI should be pretty short imo, we don't need to mention every detail there.

Maybe it should just link to the full details, in fact.

// reflect on their types in any way.
//
// By default we do not make this assumption, and assume anything that escapes
// to the outside may be inspected in detail, which prevents us from e.g.
Expand Down
Loading