Skip to content

RemoveUnusedModuleElements: Referenced elems refer to their offsets #8750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 1 commit into from
May 21, 2026
+45 −0
Merged

RemoveUnusedModuleElements: Referenced elems refer to their offsets #8750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/passes/RemoveUnusedModuleElements.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,9 @@ struct Analyzer {
} else if (kind == ModuleElementKind::ElementSegment) {
// TODO: We could empty out parts of the segment we don't need.
auto* segment = module->getElementSegment(value);
if (segment->offset) {
addReferences(segment->offset);
}
for (auto* item : segment->data) {
addReferences(item);
}
Expand Down
42 changes: 42 additions & 0 deletions test/lit/passes/remove-unused-module-elements_tnh.wast
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,3 +236,45 @@
;; T_N_H: (export "mem" (memory $mem))
(export "mem" (memory $mem))
)

;; The exported function has a call_indirect, which refers to the table and
;; elem. The elem refers to the global, so it must not be removed (in either TNH
;; or not).
(module
;; CHECK: (type $nop (func))
;; T_N_H: (type $nop (func))
(type $nop (func))

;; CHECK: (global $g i32 (i32.const 0))
;; T_N_H: (global $g i32 (i32.const 0))
(global $g i32 (i32.const 0))

;; CHECK: (table $table 50 50 funcref)
;; T_N_H: (table $table 50 50 funcref)
(table $table 50 50 funcref)

;; CHECK: (elem $elem (global.get $g) $func)
;; T_N_H: (elem $elem (global.get $g) $func)
(elem $elem (global.get $g) $func)

;; CHECK: (export "func" (func $func))

;; CHECK: (func $func (type $nop)
;; CHECK-NEXT: (call_indirect $table (type $nop)
;; CHECK-NEXT: (i32.const 0)
;; CHECK-NEXT: )
;; CHECK-NEXT: )
;; T_N_H: (export "func" (func $func))

;; T_N_H: (func $func (type $nop)
;; T_N_H-NEXT: (call_indirect $table (type $nop)
;; T_N_H-NEXT: (i32.const 0)
;; T_N_H-NEXT: )
;; T_N_H-NEXT: )
(func $func (export "func") (type $nop)
(call_indirect (type $nop)
(i32.const 0)
)
)
)

Loading