Fix test_cluster_fuzz.py V8 flags mismatch#8746
Merged
Merged
Conversation
When running test_cluster_fuzz.py, it was launching V8 with a hardcoded list of flags, instead of reading the flags from the generated flags file. This caused V8 to fail compilation of test cases that included relaxed atomics (which are generated by default now since relaxed atomics fuzzing was enabled), because V8 requires --experimental-wasm-acquire-release flag for them, and this flag was not in the hardcoded list. This CL fixes this by reading the flags from the generated flags file to faithfully simulate how ClusterFuzz runs V8.
Member
Author
|
(I don't know if the PR description is correct about the normal use of flags files, but it seems plausible. Please double-check that this makes any sense at all.) |
kripken
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running test_cluster_fuzz.py, it was launching V8 with a hardcoded list
of flags, instead of reading the flags from the generated flags file.
This caused V8 to fail compilation of test cases that included relaxed atomics
(which are generated by default now since relaxed atomics fuzzing was enabled),
because V8 requires --experimental-wasm-acquire-release flag for them, and this
flag was not in the hardcoded list.
This CL fixes this by reading the flags from the generated flags file to
faithfully simulate how ClusterFuzz runs V8.