[NFC] Refactor closedWorld to WorldMode enum#8740
Open
tlively wants to merge 2 commits into
Open
Conversation
Replace the `closedWorld` boolean in `PassOptions` with a `WorldMode` enum which has `Closed` and `Open` variants. Also introduce `ModuleUtils::getExposedPublicHeapTypes` to collect directly exposed public types, and updates `getPublicHeapTypes` to take `WorldMode` as a parameter. These refactorings will make a subsequent commit changing how we collect public heap types in open-world mode simpler.
kripken
reviewed
May 21, 2026
| // handle direct calls in fixClosedWorld, but cannot handle indirect ones | ||
| // easily, so just disallow taking references of those functions. | ||
| if (!closedWorld) { | ||
| if (worldMode != WorldMode::Closed) { |
Member
There was a problem hiding this comment.
Suggested change
| if (worldMode != WorldMode::Closed) { | |
| if (worldMode == WorldMode::Open) { |
Member
There was a problem hiding this comment.
In other places too, or was there a reason to prefer the !=?
Member
Author
There was a problem hiding this comment.
No, I can make it consistently use ==
Update all occurrences of != WorldMode::Closed introduced by the world mode refactoring commit to use == WorldMode::Open instead, in response to reviewer feedback.
kripken
reviewed
May 21, 2026
| // module, i.e. the types that would appear in the type section. | ||
| std::vector<HeapType> collectHeapTypes(Module& wasm); | ||
|
|
||
| std::vector<HeapType> getExposedPublicHeapTypes(Module& wasm); |
Member
There was a problem hiding this comment.
This needs a comment, I think - how does it differ from getPublicHeapTypes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the
closedWorldboolean inPassOptionswith aWorldModeenum which hasClosedandOpenvariants. Also introduceModuleUtils::getExposedPublicHeapTypesto collect directly exposed public types, and updatesgetPublicHeapTypesto takeWorldModeas a parameter. These refactorings will make a subsequent commit changing how we collect public heap types in open-world mode simpler.