[NFC] Remove unused additionalPrivateTypes#8136
Merged
Merged
Conversation
GlobalTypeRewriter methods previously took an optional list of extra types to consider private and therefore eligible to be modified. Remove this parameter because it is not used.
kripken
reviewed
Dec 16, 2025
| }; | ||
|
|
||
| // Check if a type is private, looking for its info (if there is none, it is | ||
| // not private). |
Member
There was a problem hiding this comment.
The comment no longer matches the code below.
Why did the code change?
Member
Author
There was a problem hiding this comment.
isPublicGivenInfo is no longer necessary because we no longer need to check additionalSet. I believe the it == typeInfo.end() branch was also dead (fuzzer to verify).
kripken
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GlobalTypeRewriter methods previously took an optional list of extra
types to consider private and therefore eligible to be modified. Remove
this parameter because it is not used.