[CI] Add ruff python checker. NFC#8131
Merged
Merged
Conversation
tlively
reviewed
Dec 15, 2025
Member
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Do you know how much overlap this has with flake8?
Member
Author
There is a great deal overlap, and ruff and pretty much replace flake8. There are couple of exception, for example some ruff checks that flake includes are still marked as experimental. See https://github.com/emscripten-core/emscripten/blob/b3836dc134fac64639df26f720c42593fe590d47/.circleci/config.yml#L548-L549 So for now it seems simpler just to run both. They are very cheap compared to everything else we do in CI. |
sbc100
force-pushed
the
ruff_check
branch
4 times, most recently
from
065627a to
41b88d8
Compare
tlively
approved these changes
Dec 16, 2025
sbc100
force-pushed
the
ruff_check
branch
3 times, most recently
from
23987ee to
378d964
Compare
Member
Author
|
@kripken could you cast an eye over fuzz_opt.py? Its one of the files with the more complex changes to it. |
sbc100
force-pushed
the
ruff_check
branch
2 times, most recently
from
24be319 to
853f163
Compare
kripken
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.