Fix uninitialized member#8094
Merged
Merged
Conversation
stevenfontanella
force-pushed
the
uninitialized-member
branch
from
7b8d24d to
c2eb4ea
Compare
kripken
pushed a commit
to kripken/binaryen
that referenced
this pull request
Dec 10, 2025
std::array is an aggregate type with a C array as a member so its default initialization is garbage. Change it to value initialization to ensure that it has a defined value which removes the need for disabling the warnings and fixes the Alpine CI build.
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::array is an aggregate type with a C array as a member so its default initialization is garbage. Change it to value initialization to ensure that it has a defined value which removes the need for disabling the warnings and fixes the Alpine CI build.