Add asyncify-export-globals argument#8074
Merged
Merged
Conversation
sbc100
force-pushed
the
asyncify_export_globals
branch
3 times, most recently
from
a0f5fb1 to
2b9ba4a
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Nov 26, 2025
kripken
reviewed
Nov 27, 2025
kripken
reviewed
Nov 27, 2025
sbc100
force-pushed
the
asyncify_export_globals
branch
2 times, most recently
from
ebbfd5f to
dad5fc6
Compare
kripken
reviewed
Dec 1, 2025
| // | ||
| // In addition, there are arguments for controlling the import/export of the | ||
| // internal globals used by Asyncify. These can be useful in dynamic linking. | ||
| // By default these globals are are internal and neither imported, not exported. |
Member
There was a problem hiding this comment.
Suggested change
| // By default these globals are are internal and neither imported, not exported. | |
| // By default these globals are are internal and neither imported nor exported. |
sbc100
force-pushed
the
asyncify_export_globals
branch
from
dad5fc6 to
f20aa5b
Compare
In the past emscripten would build the main module as relocatable, but these days we build it statically and in that case it makes sense for the main module to define and export these globals, rather than defining them in JS.
sbc100
force-pushed
the
asyncify_export_globals
branch
from
f20aa5b to
5e045d9
Compare
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 1, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 1, 2025
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Dec 2, 2025
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Dec 2, 2025
inolen
pushed a commit
to inolen/emscripten
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the past emscripten would build the main module as relocatable, but these days we build it statically and in that case it makes sense for the main module to define and export these globals, rather than defining them in JS.