[CI] Test on oldest supported Ubuntu version as well as latest. NFC#8071
Merged
Conversation
kripken
approved these changes
Nov 26, 2025
This ensures we don't break the emsdk builder which builds binaryen on a pinned/older version of Ubuntu (currently 20.24 / Focal).
sbc100
force-pushed
the
test_on_older_ubuntu
branch
from
a7be8e1 to
3e90522
Compare
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Nov 26, 2025
Member
|
So IIUC this means that we now require Ubuntu 22.04 to build Binaryen (or more precisely, I guess we are requiring whatever version of libstdc++ is on that distro)? |
Member
Author
I'm not sure. We do know that binaryen currently does not build on 20.04. But github doesn't have a 20.04 imagine anymore to test with. |
Member
|
Well the bug in #8067 sure looks like an issue with libstdc++ based on the error and the CL that started it. |
dschuff
approved these changes
Nov 26, 2025
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Nov 26, 2025
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
Nov 26, 2025
This allows us compile binaryen from source during CI, which was broken recently. See WebAssembly/binaryen#8067 and WebAssembly/binaryen#8071
wtu87830895-svg
pushed a commit
to wtu87830895-svg/emsdk2
that referenced
this pull request
Dec 20, 2025
This allows us compile binaryen from source during CI, which was broken recently. See WebAssembly/binaryen#8067 and WebAssembly/binaryen#8071
mmorel-35
pushed a commit
to mmorel-35/emsdk
that referenced
this pull request
Feb 3, 2026
This allows us compile binaryen from source during CI, which was broken recently. See WebAssembly/binaryen#8067 and WebAssembly/binaryen#8071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures we don't break the emsdk builder which builds binaryen on a pinned/older version of Ubuntu (emsdk currently uses currently 20.24 / Focal but github doesn't support 20.24 anymore sadly).
If we can land this it should prevent bugs like #8067 from re-occurring.