Improve fuzzing of Two#8006
Merged
Merged
Conversation
tlively
reviewed
Oct 30, 2025
Comment on lines
+1805
to
+1807
| # The reduce.sh script will then do the right thing, using that as the first | ||
| # wasm, and reducing on the second one, if you replace "original.wasm" in the | ||
| # command with "second.wasm" as needed. |
Member
There was a problem hiding this comment.
Does this mean replacing "original.wasm" in the text of reduce.sh? If not, which "original.wasm" is this referring to?
It would be useful to print these instructions in the fuzzer error message that provides the reduction command.
Member
Author
There was a problem hiding this comment.
"original.wasm" appears in the command that the fuzzer tells you to run. I clarified this now.
Comment on lines
+1817
to
+1819
| # Generate a second wasm file. (For fuzzing, we may be given one, but we | ||
| # still generate it to avoid changes to random numbers later; we just | ||
| # discard it after.) |
Member
There was a problem hiding this comment.
This comment doesn't quite agree with the code below, which only generates the second module when it is not given.
Member
Author
There was a problem hiding this comment.
Ah, yes, we only prepare to generate it. The actual generation consumes no randomness here. I clarified the text now.
tlively
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finally found out how to make this not horrible:
the second file is provided (or else reductions can fail weirdly).
BINARYEN_FIRST_WASMis provided (which means the first is to be kept fixed).