chore: [fuzz] only emit call-export and call-export-catch when exception handling is enabled#8001
Closed
Changqing-JING wants to merge 2 commits into
Closed
chore: [fuzz] only emit call-export and call-export-catch when exception handling is enabled#8001Changqing-JING wants to merge 2 commits into
Changqing-JING wants to merge 2 commits into
Conversation
Changqing-JING
changed the title
…ion handling is enabled
Changqing-JING
force-pushed
the
chore/fuzz-call-export
branch
from
1b82cdb to
5f53e59
Compare
Member
|
In what sense are they useless? The catching is on the JS side, which can catch wasm traps, which occur even without wasm exceptions being enabled. |
Contributor
Author
|
When a user generates mvp Wasm module, the Wasm module never throw, then nothing can be catch in JS |
Member
|
But even in MVP, division by zero will trap. The trap becomes a thrown exception on the JS side, which can be caught there. |
Contributor
Author
|
Thank you for this kindly explanation. I closed this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If exception is not enabled, call-export and call-export-catch are useless