[test] Remove test/spec/expected-output. NFC

[sbc100]

For some reason these 4 tests had expected output but no others. The spec tests work based on internal assertions so comparing output should not be needed.

[tlively]

Looks like they're still used by other tests.

[sbc100]

Am I wrong about this? Do we care about the output of these tests in this way?

[sbc100]

It seems like if we do care about the stdout of the tests we should care about all of them, not just these 4.

[stevenfontanella]

I think the stdout is only checked in these tests because they're the only ones that print e.g. func_ptrs.wast. The logic for printing is sort of special: link. Do we have something else that will exercise the logic if we remove these tests?

[sbc100]

Good point, yes. It would be annoying if we should detect failures of the print import.

Does the upstream spec tests check output like this though? Its seems odd that we could add golden files for tests that are based on assertions instead.

Maybe a better approach would be write some specific tests for the print import? I certainly wouldn't want to land this without that first I guess.

I'll abandon this PR I think since these golden files kind of act as a test for the print import, even if its a bit overkill in terms of the whole golden file thing.

[tlively]

Does the upstream spec tests check output like this though?

Running the upstream spec tests does produce e.g. imports.wast.log, but it doesn't look like anything is checking its output.