Implement friends-only indicator (#1104)#1433
Open
huntertur wants to merge 1 commit intoWeasyl:mainfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage 61.55% 61.55%
=======================================
Files 96 96
Lines 9219 9219
Branches 1659 1659
=======================================
Hits 5675 5675
Misses 3085 3085
Partials 459 459 ☔ View full report in Codecov by Sentry. |
Contributor
|
I noticed that the https://www.weasyl.com/journals/(username) doesn't show the rating or friends-only status of journals. If @charmander thinks it's needed, it'd be nice to get it in on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #1104.
Some notes:
/journals/username) doesn't currently show mature/explicit indicators, so I left that page alone. Maybe I could open an issue for that one and take a look into adding indicator support in general as a separate item.pinkinstead of eyedropper-picking the existing color for Friends Only because I feel it is too close to the color used by the explicit indicator and could be therefore be confusing.Examples of how this looks