fix(create-robo): dependencies and cli - #476
Open
Asys-sh wants to merge 1 commit into
Open
Conversation
fix(create-robo): align ESLint deps and allow Robo prereleases
Pin generated ESLint dependencies to matching major 10 versions so npm
does not resolve @eslint/js@10 alongside eslint@9 and fail with ERESOLVE.
ESLint 10 requires JITI to load the eslint config when using typescript, added that too (owo)
Relax @robojs/discordjs peer dependency on robo.js from ^0.11.0 to
>=0.11.0-0 <0.12.0 so prerelease builds like 0.11.0-next.1 satisfy the
peer range while still staying inside the 0.11 compatibility line.
The new robo CLI accepted and the create-robo tool were differing in terms of signature
so actually using npx create-robo@next was failing due to not decomposing the object properly like :
````
.handler(async (args, options) => {})
````
vs
````
{
args,
options,
logger,
cwd,
argv
}
````
since create-cli expected parameters to be laid out different it would make it crash saying "cannot destructure property of env as options as it is undefined"
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
create-discord-activity
create-robo
@robojs/server
@robojs/better-stack
@roboplay/plugin-confessions
@robojs/dev
@roboplay/plugin-gpt
@robojs/maintenance
@robojs/moderation
@roboplay/plugin-poll
@robojs/sync
robo.js
@roboplay/sage
@robojs/ai
@robojs/analytics
@robojs/auth
@robojs/cli
@robojs/code
@robojs/cron
@robojs/discordjs
@robojs/flashcore-extras
@robojs/giveaways
@robojs/i18n
@robojs/mock
@robojs/patch
@robojs/roadmap
@robojs/trpc
@robojs/xp
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To merge later.