Skip to content

fix(@robojs/server): tunnels creation - #475

Open
Asys-sh wants to merge 2 commits into
nextfrom
fix(server/tunnels)
Open

fix(@robojs/server): tunnels creation#475
Asys-sh wants to merge 2 commits into
nextfrom
fix(server/tunnels)

Conversation

@Asys-sh

@Asys-sh Asys-sh commented May 19, 2026

Copy link
Copy Markdown
Contributor

Fixing tunnels not creating the actual re routing for the tunnel.

This also fixed another issue where if credentials were set in .env, it would return early, it does not anymore and proceeds to check everything still to make sure tunnel is correctly setup.

Also ran into a bug for the DNSRecord where passing nested parameters would turn it into [Object object] using URLSearchParams (nested fields are not supported) flattened it.

I also removed the DNSRecordFilter, it seemed too broad to fetch everything that contained robo but people could have other stuff with the same ? and maybe now its too narrow ? please let me know your thoughts,

Asys-sh added 2 commits May 19, 2026 17:33
Fixing tunnels not creating the actual re routing for the tunnel.

This also fixed another issue where if credentials were set in .env, it would return early, it does not anymore and proceeds to check everything still to make sure tunnel is correctly setup.

Also ran into a bug for the DNSRecord where passing nested parameters would turn it into [Object object] using URLSearchParams (nested fields are not supported) flattened it.

I also removed the DNSRecordFilter, it seemed to broad to fetch everything that contained robo (let me know if I am wrong) but people could have other stuff with the same ?
Moved function call as you mentionned in another PR :3
@coderabbitai

coderabbitai Bot commented May 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d6a661ef-8183-40a5-bcb5-21a12f0a163a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix(server/tunnels)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented May 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

create-discord-activity

npm i https://pkg.pr.new/Wave-Play/robo.js/create-discord-activity@475

create-robo

npm i https://pkg.pr.new/Wave-Play/robo.js/create-robo@475

@robojs/server

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/server@475

@robojs/better-stack

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/better-stack@475

@roboplay/plugin-confessions

npm i https://pkg.pr.new/Wave-Play/robo.js/@roboplay/plugin-confessions@475

@robojs/dev

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/dev@475

@roboplay/plugin-gpt

npm i https://pkg.pr.new/Wave-Play/robo.js/@roboplay/plugin-gpt@475

@robojs/maintenance

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/maintenance@475

@robojs/moderation

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/moderation@475

@roboplay/plugin-poll

npm i https://pkg.pr.new/Wave-Play/robo.js/@roboplay/plugin-poll@475

@robojs/sync

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/sync@475

robo.js

npm i https://pkg.pr.new/Wave-Play/robo.js@475

@roboplay/sage

npm i https://pkg.pr.new/Wave-Play/robo.js/@roboplay/sage@475

@robojs/ai

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/ai@475

@robojs/analytics

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/analytics@475

@robojs/auth

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/auth@475

@robojs/cli

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/cli@475

@robojs/code

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/code@475

@robojs/cron

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/cron@475

@robojs/discordjs

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/discordjs@475

@robojs/flashcore-extras

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/flashcore-extras@475

@robojs/giveaways

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/giveaways@475

@robojs/i18n

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/i18n@475

@robojs/mock

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/mock@475

@robojs/patch

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/patch@475

@robojs/roadmap

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/roadmap@475

@robojs/trpc

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/trpc@475

@robojs/xp

npm i https://pkg.pr.new/Wave-Play/robo.js/@robojs/xp@475

commit: bb7562c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant