fix(@robojs/server): tunnels creation - #475
Conversation
Fixing tunnels not creating the actual re routing for the tunnel. This also fixed another issue where if credentials were set in .env, it would return early, it does not anymore and proceeds to check everything still to make sure tunnel is correctly setup. Also ran into a bug for the DNSRecord where passing nested parameters would turn it into [Object object] using URLSearchParams (nested fields are not supported) flattened it. I also removed the DNSRecordFilter, it seemed to broad to fetch everything that contained robo (let me know if I am wrong) but people could have other stuff with the same ?
Moved function call as you mentionned in another PR :3
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
create-discord-activity
create-robo
@robojs/server
@robojs/better-stack
@roboplay/plugin-confessions
@robojs/dev
@roboplay/plugin-gpt
@robojs/maintenance
@robojs/moderation
@roboplay/plugin-poll
@robojs/sync
robo.js
@roboplay/sage
@robojs/ai
@robojs/analytics
@robojs/auth
@robojs/cli
@robojs/code
@robojs/cron
@robojs/discordjs
@robojs/flashcore-extras
@robojs/giveaways
@robojs/i18n
@robojs/mock
@robojs/patch
@robojs/roadmap
@robojs/trpc
@robojs/xp
commit: |
Fixing tunnels not creating the actual re routing for the tunnel.
This also fixed another issue where if credentials were set in .env, it would return early, it does not anymore and proceeds to check everything still to make sure tunnel is correctly setup.
Also ran into a bug for the DNSRecord where passing nested parameters would turn it into [Object object] using URLSearchParams (nested fields are not supported) flattened it.
I also removed the DNSRecordFilter, it seemed too broad to fetch everything that contained robo but people could have other stuff with the same ? and maybe now its too narrow ? please let me know your thoughts,