Add support for up to 15 profiles#10
Open
sammko wants to merge 2 commits into
Open
Conversation
Author
There was a problem hiding this comment.
Reverse the bit-order in the current_profile nibble and put it in revprofile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the 3 profile LEDs also have an orange LED, and using the binary system with 4 bits, I could fit 16 profiles in. However that would require one of the profiles being 0 and none of the LEDs would be lit which I didn't like, so I just made it 15 profiles. I can't imagine anyone using that many profiles, but meh, why not :).