Consolidate development history and restore passing mainline validation - #5
Merged
Merged
Conversation
- Theme accent and hexagon gradient adopt the canonical SVG green stops (#0C7428 / #0B7026 / #0A6822); soft accent tint moves to #E8F5E9 - Regenerate LogoInstaller.ico from the updated vector theme - Rename the shell accent contract test and invert its palette assertions
Owner
Author
|
Closing this draft so the repository has no open pull requests. This branch remains the recovery entry for settings-generation work. It is not merged because:
Resume from those branches; do not treat this closed draft as discarded source. 关闭此草稿 PR,仓库不再保留 Open 的 Pull Request。 |
Water-Run
marked this pull request as ready for review
September 22, 2026 11:53
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidates the remaining settings-generation and installer-cleanup history into
main, preserving every unique commit and the existing green manager branding. Production credential separation, accent validation, and repository lifetime fixes are included; the latest mainline Persian/RTL changes are retained.Fixes the CA1304 errors that blocked mainline builds and packaging, updates the missed Persian settings assertions, and fixes cleanup-source analysis/format failures. Keeps the unfinished directory ownership modules available without activating their isolated creation hook before terminal recovery and finalization are connected. Production preferences continue to use LocalSettings until the complete generation cutover is implemented.
Adds the 2026-09-22 development report, updates all four READMEs and historical recovery links, and records the single-main branch policy. Settings production cutover, automatic directory cleanup, native interaction acceptance, and formal release remain explicit follow-up work.
Validation: pinned locked restore; all 18 projects build Release x64 with zero warnings/errors; 5178 local tests pass with zero failures/skips (2938 main, 1022 Core, 143 Presentation, 1075 Windows). Format validates 1539 files. PowerShell 5.1/7 syntax, icon, packaging/runtime, build-profile, third-party notice, and Sandbox report/startup contracts pass. The local filter excludes two certificate-store test classes containing 20 cases; isolated CI runs all of them. No formal release or new native installation acceptance is claimed.
CI for 83f3058 passed both jobs: https://github.com/Water-Run/ClashSharp/actions/runs/35724023117. All four downloaded TRX reports confirm 5198 passed, zero failed/skipped (2938 main, 1022 Core, 143 Presentation, 1095 Windows). The complete development package artifact is 317846956 bytes. Merge commit af35185 has exactly the tested tree. All former branch heads are preserved in main history; the repository now has only main locally and on origin, with zero open pull requests.