Repository navigation
Lennon amos integration - #15
Merged
Merged
Conversation
Hotswapping a different wallpaper left the previous audio running, and the new wallpaper often stayed blank until something else changed, such as moving it. A path change now starts a new engine process. Volume 0 is included in that swap, so a muted wallpaper stays muted when it is applied on another screen. The volume slider ignored its own 100% event. That event fired when the panel re-rendered and overwrote a real 0, so the slider did nothing until it was muted and dragged back to 100%. Assigned wallpapers are launched again on startup. A live engine already showing the same wallpaper is left alone, and a screen a playlist just resumed is left to the playlist. Play from a card in per-screen mode asks which screen to use.
A path change no longer forces a new engine process. That restart dropped transitions and made every playlist advance, schedule rule, and tray next/previous blank the screen. Volume 0 is still sent on the hotswap. Restore leaves a running split alone, and skips a wallpaper whose folder or project.json is missing, so an unmounted library disk cannot mark it as a launch crash. The volume slider ends the drag on pointer cancel, lost capture, and blur.
Restore runs after the tray, autostart and schedule, and it is not awaited. Screens a playlist resumed, a playlist that was not resumed, an autostart playlist, or a schedule catch-up is about to use are skipped. A split that is not running comes back through showSplitScreen when the assignment is its first slot. Static images are left alone, and the unused forceFresh on that launch is gone. Card Play asks with the in-app screen list. All screens is the default, so Enter still applies to every screen. The shared slider helper is in place for the detail panel.
Hotswap stays the default, and volume 0 is still sent. The setting skips the hotswap when the wallpaper path changes. The same path, a forced fresh launch and a missing engine behave as before.
The volume slider and the other range inputs share one helper. A change that arrives on its own cannot write the range max over the drag, including 0.
Off by default. Playlists, schedules and the tray restart the engine too when it is on.
Card Play uses the same screen question as the other Play buttons. All screens stays the default. Esc cancels, and Tab stays in the dialog. Applying one wallpaper clears that screen's split, so the next start does not bring the split back just because the wallpaper is its first slot. Restore checks each screen again before launching it. A screen whose assignment changed, or that was launched or stopped while an earlier screen was starting, is left as it is. A missing dependency on that path is skipped instead of opening a dialog. The don't-resume hint says those screens stay blank after a restart.
…, keep volume 0)
- Playlists: daytime, day of week, never and logon modes, schedule helpers in shared/playlistSchedule - Application rules and profiles, with rule actions shared with the schedule - Audio input device setting, background and quick video optimize, video tools and defaults in settings - Kill all: optional pausing of playlists, and a separate switch for the integration branch's behavior (suspend, stop the playlists and forget the wallpapers); both off keeps the plain kill - Process lookup helpers for the app rules - Packaging: local rpm build script, release notes for 0.9.8 to 0.9.10, electron 45.2.3 Merged onto the integration branch: the clock modes sit on top of its showCurrent/resumePlayer playlist player, and the rule actions use its isShownOn check for the applied counter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.