Skip to content

Changes made on the private repo for uncertainties paper#363

Merged
jorindevandevis merged 25 commits intoWall-Go:mainfrom
jorindevandevis:changesApplicationsRepo
Aug 29, 2025
Merged

Changes made on the private repo for uncertainties paper#363
jorindevandevis merged 25 commits intoWall-Go:mainfrom
jorindevandevis:changesApplicationsRepo

Conversation

@jorindevandevis
Copy link
Collaborator

@jorindevandevis jorindevandevis commented Aug 20, 2025

This is a PR for all changes made on a private repository that we used for our upcoming paper investigating the uncertainties in the bubble wall velocity.

benoitlaurent96 and others added 14 commits August 20, 2025 17:31
@benoitlaurent96 @jorindevandevis
Merge pull request Wall-Go#5 from Wall-Go/linearisation
9d19ed1 
Implemented the new linearisation criterion
@og113 @jorindevandevis
Merge pull request Wall-Go#7 from Wall-Go/aliasing
a654a36 
Spectral truncation
@og113 @jorindevandevis
Merge pull request Wall-Go#9 from Wall-Go/includeAliasingError
ebe6532 
Error estimate moved after auto truncation
@benoitlaurent96 @jorindevandevis
Merge pull request Wall-Go#15 from Wall-Go/tanhError
ff611e8 
Tanh error
@jorindevandevis
Merge pull request Wall-Go#19 from Wall-Go/userFreeEnergy
5a59347 
User-provided free energy
@benoitlaurent96 @jorindevandevis
Merge pull request Wall-Go#20 from Wall-Go/fixPhaseTracing2
e929b36 
Fix phase tracing2
@jorindevandevis
Merge pull request Wall-Go#25 from Wall-Go/EMconservation
11962a2 
EM conservation/violation
@jorindevandevis
Merge pull request Wall-Go#29 from Wall-Go/moreLightHiggsPhaseTraceNew
d65117d 
Light Higgs phase trace test
@joonashir @jorindevandevis
Merge pull request Wall-Go#30 from Wall-Go/vwError
db001b9 
Changed the calculation of the wall velocity error
@jorindevandevis
Merge pull request Wall-Go#32 from Wall-Go/examplePTTools
d9a71c5 
Example file for exporting thermodynamics
@jorindevandevis
Merge pull request Wall-Go#34 from Wall-Go/collisionPair
2d5824f 
A fix to results.setViolationOfEMConservation
@og113 @jorindevandevis
Merge pull request Wall-Go#36 from Wall-Go/CHANGELOGv1.1.0
b0168d0 
Changelog v1.1.0
@jorindevandevis
Merge pull request Wall-Go#37 from Wall-Go/collisionPair2
44ae253 
Collision pair generation
@jorindevandevis
Remove some files
0510297
@jorindevandevis jorindevandevis requested a review from og113 August 20, 2025 15:57
@og113 @jorindevandevis
Merge pull request Wall-Go#28 from Wall-Go/FixLoggingPrints
138eb21 
Truncation update, and printing fixes
og113
og113 reviewed Aug 20, 2025
View reviewed changes
og113
og113 previously approved these changes Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@og113 og113 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that the tests pass locally, and the Model files run as expected locally. I've also compared the files against those in the Applications repo and everything looks as expected.

@pschicho pschicho self-requested a review August 21, 2025 14:24
@benoitlaurent96 benoitlaurent96 self-requested a review August 21, 2025 14:42
pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
src/WallGo/boltzmann.py
import importlib


class ETruncationOption(Enum):
Copy link
Collaborator

@pschicho pschicho Aug 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this classname descriptive enough?

Copy link
Collaborator Author

@jorindevandevis jorindevandevis Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say TruncationOption is quite descriptive. What is your concern?

Copy link
Collaborator

@pschicho pschicho Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be TruncationEstimateOption? I was just confused by the "E" in front.

Copy link
Collaborator

@og113 og113 Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have used the same convention for other Enums across WallGo, including WallGo.EExtrapolationType, WallGo.ESolutionType and WallGoCollision.EParticleType. I think the convention was introduced by Lauri. I don't think we should consider changing it in this PR.

pschicho
pschicho reviewed Aug 21, 2025
View reviewed changes
Copy link
Collaborator

@pschicho pschicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the PR and ran tests and examples. I didn't run examples with new collision integration though.

  • Tests pass
  • Examples did not cause errors
  • Update collisions if needed?

@pschicho
Copy link
Collaborator

pschicho commented Aug 21, 2025

For yukawa.py, I get less detailed out put and the following overflow issue:

/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in cosh
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2
/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in square
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2

@og113
Copy link
Collaborator

og113 commented Aug 21, 2025

For yukawa.py, I get less detailed out put and the following overflow issue:

/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in cosh
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2
/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in square
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2

See Issue #364. The less detailed output is because the logging level is higher.

benoitlaurent96
benoitlaurent96 previously approved these changes Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@benoitlaurent96 benoitlaurent96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't had the time to review all the files changed, but everything seems to work as intended locally. Great job everybody!

@og113
Update equationOfMotion.py
d9bcbf3 
Ignoring overflow warnings where we think they are benign
@og113
Copy link
Collaborator

og113 commented Aug 26, 2025

For yukawa.py, I get less detailed out put and the following overflow issue:

/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in cosh
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2
/Users/schicho/Documents/projects/wallgo/path/to/WallgoVenv/lib/python3.13/site-packages/WallGo/equationOfMotion.py:1585: RuntimeWarning: overflow encountered in square
  / np.cosh(z[:, None] / wallParams.widths[None, :] + wallParams.offsets) ** 2

This is fixed in d9bcbf3

@jorindevandevis
Copy link
Collaborator Author

jorindevandevis commented Aug 28, 2025

I think everything has been addressed now. There is just one open question from Philipp about the name ETruncationOption.
I don't know the answer, I assumed it was standard naming for Enums?

@og113
Update __init__.py
57c2c4b 
Added ESolutionType from results, as it is already a type which is exposed to the user.
pschicho
pschicho approved these changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@pschicho pschicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments resolved. I think, we can merge now.

@jorindevandevis jorindevandevis merged commit 7a8cc1d into Wall-Go:main Aug 29, 2025
6 checks passed
This was referenced Aug 29, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@og113 og113 og113 left review comments

@pschicho pschicho pschicho approved these changes

@benoitlaurent96 benoitlaurent96 benoitlaurent96 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jorindevandevis @pschicho @og113 @benoitlaurent96 @joonashir