varlock: adopt selective shared imports#340
Merged
Merged
Conversation
Import only reusable provider credentials from optional shared and Rafiki-local sources while retaining the app schema as the contract. Scope audit and scan guidance to source-controlled inputs and add sanitized present/missing fixture coverage.
Agentic PR ReviewVerdict: needs-human Checks:
This PR is not blocked from human review, but the agentic gate is not satisfied. |
Agentic PR ReviewVerdict: review-ready Checks:
|
Agentic PR ReviewVerdict: review-ready Checks:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #339
Summary
pickandallowMissing=trueVerification
python3 -m pytest -q tests/test_varlock_contract.py- 4 passednpm test- 518 passed, 1 skipped, 1 upstream dependency warningnpm run pack:check- passed, 147 package filesnpm run doctor- passed with 0 critical issues and expected missing-provider/MCP warningsnpm run env:audit- passed, schema and code references in sync across 153 scoped filesnpm run env:scan- passed against staged changesvarlock load --agent --show-allwith a sanitized HOME and the optional shared source absent - passedvarlock run --inject vars -- ...for present and missing sanitized fixtures - passedvarlock scanfor present and missing sanitized fixtures - passedgit diff --check- passedValidated with standalone Varlock 1.10.0. No live value files, process values, credential stores, user-level launchers, cloud configuration, or production surfaces were read or changed.
Acceptance Self-Check