Merged
Conversation
P0071 | First time user flow
P0070 | User list on 36Blocks panel
prakharlowanshi11
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
Other comments (6)
- apps/proxy/src/app/features/create-feature/create-feature.component.ts (582-583) The logo URL is only being set in the component property (`this.logoUrl`) but not in the form control. This could cause inconsistency when submitting the form. Consider uncommenting line 582 or ensuring the form value is properly synchronized with the component state.
-
apps/proxy/src/app/users/user/user.component.html (156-159)
The Last Login column might display 'Invalid Date' if `last_login_at` is null or undefined. Consider adding a fallback:
<span> {{ element?.last_login_at ? (element?.last_login_at | date: 'd MMM y') : '-' }} </span> <span *ngIf="element?.last_login_at">({{ element?.last_login_at | date: 'mediumTime' }})</span> -
apps/proxy/src/app/users/user/user.component.html (146-146)
The Block Name column should have a fallback value when `feature_configuration` or its `name` property is null/undefined:
{{ element?.feature_configuration?.name || '-' }} - apps/proxy/src/app/features/create-feature/create-feature.component.html (904-905) There are inconsistent color handling approaches in the UI. Some elements use hardcoded colors while others use dynamic values from the form. Consider using CSS variables consistently for all themed elements to ensure proper theme switching.
-
apps/proxy/src/styles.scss (108-113)
This PR adds commented-out CSS code that should either be implemented or removed. Commented code adds unnecessary noise to the codebase and can lead to confusion about whether it's intended for future use or is deprecated code that was never removed.
- apps/proxy/src/app/features/create-feature/create-feature.component.ts (755-761) There are commented out UI preferences in the 'authorization' case of the updateFeature method. Since UI preferences are now handled in the 'branding' case, these commented lines should either be removed or a comment should be added explaining why they're kept.
💡 To request another review, post a new comment with "/windsurf-review".
apps/proxy/src/app/features/create-feature/create-feature.component.html
Show resolved
Hide resolved
apps/proxy/src/app/features/create-feature/create-feature.component.html
Show resolved
Hide resolved
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.