P0072 | Orginazation details script #429
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (2)
- apps/proxy-auth/src/app/otp/organization-details/organization-details.component.scss (238-242) The disabled form field styling in the dark theme includes `.mat-select-value-text span` (line 394) that's missing in the light theme implementation. For consistency, consider adding this selector to the light theme version as well.
- apps/proxy-auth/src/app/otp/organization-details/organization-details.component.scss (404-408) The light theme includes `.mat-form-field-outline` in the border-color selector list (line 253), but this selector is missing in the dark theme implementation. For consistency, consider adding this selector to the dark theme version as well.
💡 To request another review, post a new comment with "/windsurf-review".
| } | ||
|
|
||
| const organizationDetails = this.organizationForm.value; | ||
| const organizationDetails = this.organizationForm.getRawValue(); |
There was a problem hiding this comment.
Good change from organizationForm.value to organizationForm.getRawValue() to include the disabled timeZoneName field. Consider adding a comment explaining why getRawValue() is needed here to help future developers understand the reasoning.
| width: 100%; | ||
| z-index: 10; | ||
| max-width: 2000px; | ||
| background: transparent; |
There was a problem hiding this comment.
I notice you've removed the max-width: 2000px property from the container class. Was this intentional? Removing this constraint might cause layout issues on very large screens where content could stretch too wide.
| // this.snackBar.open(res?.data?.message ?? 'Information successfully updated', '✕', { | ||
| // duration: 3000, | ||
| // horizontalPosition: 'center', | ||
| // verticalPosition: 'top', | ||
| // panelClass: ['success-snackbar'], | ||
| // }); |
There was a problem hiding this comment.
All snackbar notifications have been commented out. Without these notifications, users won't receive any feedback when their organization details are updated successfully or when an error occurs. Consider keeping these notifications or replacing them with an alternative feedback mechanism.
2 participants
No description provided.