P0072 | Orginazation details script

[Chandan-walker]

No description provided.

[windsurf-bot]

Other comments (11)

• apps/proxy-auth/src/app/otp/send-otp/send-otp.component.html (89-91) There's a logical error in the footer condition. The expression `!type === 'user-management'` will always evaluate to false because it's parsed as `(!type) === 'user-management'` rather than `!(type === 'user-management')`. The same issue exists for the subscription check.

          class="otp-verification-footer"
          *ngIf="!authToken && type !== 'user-management' && type !== 'subscription' && referenceId"
  

• apps/proxy-auth/src/app/otp/organization-details/organization-details.component.ts (61-64) In the organization details response handler, you're trying to find a timezone by offset before the timezones array is populated (since getTimezones is called after). This could lead to undefined results. Consider restructuring the code to ensure timezones are loaded before trying to use them.
• apps/proxy-auth/src/app/otp/organization-details/organization-details.component.ts (123-128) The `tz` parameter is missing a type definition in both `getTimezoneValue` and `getTimezoneLabel` methods. Consider adding proper typing to improve type safety.

  public getTimezoneValue(tz: string | { label?: string; offset?: string }): string {
  

  public getTimezoneLabel(tz: string | { label?: string; offset?: string }): string {
  

• apps/proxy-auth/src/app/otp/organization-details/organization-details.component.ts (76-76) The empty error handlers in the subscribe blocks don't provide any feedback to the user or handle errors properly. Consider adding appropriate error handling, especially for critical operations like fetching organization details and timezones.
• apps/proxy-auth/src/app/otp/service/otp.service.ts (106-116) The authentication header approach in `getTimezones()` is inconsistent with other methods in this class. Most methods use `proxy_auth_token` while this one uses `Authorization`. Consider using a consistent authentication approach across all methods.
• apps/proxy-auth/src/app/otp/service/otp.service.ts (100-104) Modifying the shared `this.options.headers` object directly can cause side effects across method calls. Consider creating a new options object in each method (similar to what you did in `getTimezones()`) to prevent unintended header persistence between API calls.
• apps/proxy-auth/src/app/otp/service/otp.service.ts (118-125) Consider using a more specific return type for `updateCompany()` instead of `Observable`. This would improve type safety and make the API contract clearer for consumers of this service.
• apps/proxy-auth/src/app/otp/organization-details/organization-details.component.scss (44-59) The `.edit-btn` base class is missing the `border` property that's defined in both theme-specific classes. Consider adding a default border to the base class to ensure consistent rendering even if a theme class isn't applied.
• apps/proxy-auth/src/app/app.component.ts (29-38) There are several commented-out configuration options in this file. If these are meant to serve as examples or documentation, please add explanatory comments. Otherwise, consider removing unused code to improve readability.
• apps/proxy-auth/src/app/otp/organization-details/organization-details.component.scss (380-382) There's an inconsistency in the snackbar selectors. The success-snackbar uses `.mat-mdc-snack-bar-label` while the error-snackbar uses `.mat-snack-bar-label`. For consistency, both should use the same selector pattern (preferably the MDC version).

      .mat-mdc-snack-bar-label {
          color: #ffffff !important;
      }
  

• apps/proxy-auth/src/styles.scss (93-93) This commented out line appears to be debug code or an incomplete change. Please remove it before merging.

💡 To request another review, post a new comment with "/windsurf-review".

[windsurf-bot]

This PR includes what appears to be an authentication token directly in the source code. Credentials should not be stored in the codebase, even for non-production environments. Consider using environment variables or a secure credential management system instead.

[windsurf-bot]

There's a mismatch between the form control name in the error message and the actual form control. The error checks for organizationForm.get('timezone') but the form control is named timeZoneName.

Suggested change

	<mat-error *ngIf="organizationForm.get('timezone')?.hasError('required')">
	Timezone is required.
	</mat-error>
	<mat-error *ngIf="organizationForm.get('timeZoneName')?.hasError('required')">
	Timezone is required.
	</mat-error>

[windsurf-bot]

There's a potential issue in the getTimezones response handling. You check if raw is an array but then use res.data directly. If res doesn't have a data property and the value is directly in res, this could lead to undefined access.

Suggested change

	.subscribe({
	next: (res) => {
	const raw = res?.data ?? res;
	if (Array.isArray(raw)) {
	this.timezones = res.data;
	}
	},
	next: (res) => {
	const raw = res?.data ?? res;
	if (Array.isArray(raw)) {
	this.timezones = raw;
	}
	},