Skip to content

fix(ci): stop persisting a write-scoped git credential through npm ci #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wyre-agent-fleet wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): stop persisting a write-scoped git credential through npm ci #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,15 @@ jobs:
- uses: actions/checkout@v7
with:
fetch-depth: 0
# The release job declares `contents: write`, which overrides this repo's
# read-only default workflow permission -- so the checkout's default
# persisted credential is WRITE-scoped and stays live in .git/config
# through `npm ci` below. A compromised dependency lifecycle script
# could read it off disk and push. semantic-release authenticates its
# own pushes from GITHUB_TOKEN, so it does not need the persisted
# credential; `persist-credentials: false` is semantic-release's own
# documented GitHub Actions recipe. (CWE-250)
persist-credentials: false
- uses: actions/setup-node@v7
with:
node-version: 22
Expand Down