fix(ci): stop persisting a write-scoped git credential through npm ci

[wyre-agent-fleet]

Stops persisting a write-scoped git credential through npm ci (CWE-250).

The release job declares contents: write, which overrides this repo's
read-only default workflow permission — so actions/checkout's default
persisted credential was write-scoped and stayed live in .git/config
through dependency install, build and test, readable by any compromised
dependency lifecycle script during that window. persist-credentials: false
is semantic-release's own documented GitHub Actions recipe: it authenticates
its own pushes from GITHUB_TOKEN directly and never needed the persisted
credential.

Part of a pattern-set fix across WYRE-AI/node-*. Originally found and
fixed on 4 repos (node-spanning#46, node-domotz#48,
node-kaseya-quote-manager#16, node-alternative-payments#20), then a
propagation scope-check found the same pattern on 18 more repos. Full set
(18, this repo included) so reviewers can see membership:

node-axcient, node-blumira, node-clio, node-connectwise-cpq, node-datto-bcdr, node-datto-saas-protection, node-huntress, node-iqms, node-kaseya-bms, node-kaseya-vsa, node-mailprotector, node-mimecast, node-ncentral, node-proofpoint-essentials, node-rootly, node-scalepad, node-threatlocker, node-unitrends

Generated by warden's Gate-3 CWE-250 review, per boss's set-completeness ruling.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 3e502349-6228-41a2-9bc5-0b4c3f3daddd

📥 Commits

Reviewing files that changed from the base of the PR and between 2f11c8b and 4cbd0d0.

📒 Files selected for processing (2)

• .github/workflows/release.yml
• CHANGELOG.md

---

_{Comment @coderabbitai help to get the list of available commands.}

[wyre-agent-fleet]

Peer review (comment-only, per the shared-identity self-approval gate).

Verdict: approve, no blockers.

Verified independently against the actual diff content (not just warden's filing summary), as part of the 18-PR CWE-250 follow-up set-review:

• release.yml: adds persist-credentials: false to the release job's actions/checkout step, with the same explanatory comment across all 18 PRs (CWE-250: the release job's contents: write permission makes checkout's default persisted credential write-scoped and live in .git/config through npm ci; persist-credentials: false is semantic-release's own documented recipe since it authenticates pushes via GITHUB_TOKEN directly). The core fix content is byte-identical across the batch -- raw diff size varies only where a repo's pre-existing checkout step used a different YAML style (inline vs multi-line map).
• CHANGELOG.md: entry added under this repo's existing Unreleased section, correct per this repo's own convention.
• No unrelated files touched -- scope is clean.

Full batch (all independently verified): node-axcient#2, node-blumira#41, node-clio#2, node-connectwise-cpq#2, node-datto-bcdr#55, node-datto-saas-protection#55, node-huntress#43, node-iqms#39, node-kaseya-bms#48, node-kaseya-vsa#50, node-mailprotector#2, node-mimecast#44, node-ncentral#4, node-proofpoint-essentials#1, node-rootly#27, node-scalepad#2, node-threatlocker#31, node-unitrends#51

[asachs01]

Review

Change: Adds persist-credentials: false to the actions/checkout step in the release workflow, plus an inline comment explaining the rationale and a CHANGELOG entry.

Correctness: Verified — the release job declares contents: write, which overrides the repo default read-only workflow permission, so the default checkout credential is write-scoped and would otherwise sit in .git/config through npm ci/build/test. Setting persist-credentials: false is the documented semantic-release mitigation (it auths its own pushes via GITHUB_TOKEN), so the fix directly addresses the described CWE-250 exposure with no loss of functionality.

Security: This is the security fix — closes a window where a compromised dependency lifecycle script during npm ci could read a write-scoped git credential off disk. No new secrets, no injection vectors introduced. Correct placement (under the checkout step, before npm ci runs).

Code quality: Minimal, single-purpose diff. Inline comment is clear and justifies the change well.

Tests: No test coverage possible/needed for a workflow-permission change like this; acceptable for CI config.

Docs/changelog: CHANGELOG entry accurately describes the fix and matches the PR description.

No issues found. Approving.

[asachs01]

Code Review Summary — Claude Code

Verdict: Approve

Critical

None

Warnings

None

Suggestions

None

Looks Good

• Minimal, single-purpose diff scoped to .github/workflows/release.yml: adds persist-credentials: false to the actions/checkout step in the release job.
• Root cause correctly identified: the job's contents: write permission overrides the repo's read-only default, so the checkout-persisted credential was write-scoped and lived on disk in .git/config through npm ci, build, and test — a real CWE-250 exposure window if any dependency lifecycle script were compromised.
• Fix is the documented semantic-release recipe: semantic-release authenticates its own pushes via GITHUB_TOKEN and never needed the persisted git credential, so disabling persistence has no functional downside.
• Inline comment explains the "why" clearly for future maintainers.
• CHANGELOG.md updated consistently with the change.
• No test changes needed — this is a CI-config-only fix with no application code impact.

[asachs01]

Reviewed by Claude Code. Adds persist-credentials: false to actions/checkout in the release workflow so the write-scoped git credential (from this job's contents: write permission) no longer lingers in .git/config through npm ci; semantic-release still authenticates pushes via GITHUB_TOKEN, so nothing breaks. Safe and correctly scoped.

[asachs01]

Code Review Summary (Reviewed by Hermes Agent)

Looks Good

• Correctly identifies the gap: the release job's contents: write permission overrides the repo default, so actions/checkout's persisted credential is write-scoped and remains on disk through npm ci/build/test — exploitable by a compromised dependency lifecycle script (CWE-250).
• persist-credentials: false is the right, minimal fix and matches semantic-release's own documented recipe (it authenticates pushes via GITHUB_TOKEN directly, not the persisted git credential).
• Change is scoped to the checkout step only; no functional/build behavior affected.
• CHANGELOG entry documents the change clearly for downstream consumers.

Suggestions

• Consider adding this as a lint/policy check (e.g. a repo-wide CI guard) across the org's other release workflows so the pattern doesn't need to be reintroduced PR-by-PR per repo.

No security regressions introduced; fix closes the stated gap.

[asachs01]

Reviewed against the verified fleet-wide fix pattern: this diff adds persist-credentials: false to the actions/checkout step in .github/workflows/release.yml (with matching CHANGELOG entry), preventing the write-scoped git credential from persisting through npm ci in the release job (CWE-250). semantic-release authenticates its own pushes via GITHUB_TOKEN directly, so this credential was unnecessary and its removal introduces no functional regression. Matches the pattern confirmed in WYRE-AI/node-unitrends#51. Approved.

Reviewed by Hermes Agent

[asachs01]

Review — headRefOid 4cbd0d0694efd0c849ab0953cb0d40cff851a24c

Single-purpose CI fix: adds persist-credentials: false to the release job's actions/checkout step, plus a matching CHANGELOG entry.

Critical: None.

Warnings: None. The fix is correct — the release job declares contents: write, which overrides the repo's default read-only workflow permission, so the checkout step's default persisted credential is write-scoped and stays on disk through npm ci/build/test. Disabling persistence is the right mitigation (CWE-250) since semantic-release authenticates its own push from GITHUB_TOKEN, not the persisted git credential.

Suggestions: None — minimal, scoped diff; low risk.

Looks Good: Change is limited to the workflow YAML comment/flag and a changelog line; no application code touched; consistent with the same fix already applied/reviewed across the sibling node-* repos in this pattern-set.

Verdict: Comment only (already approved by reviewer; no blocking issues).

[asachs01]

Reviewed via automated sweep.

Correctness: The fix is sound. contents: write on the release job escalates actions/checkout's default persisted credential to write-scope, and it otherwise stays live in .git/config for the duration of npm ci/build/test — readable by any compromised dependency install/lifecycle script (classic CWE-250 exposure). Adding persist-credentials: false closes that window.

Verified no regression: checked the full release.yml — the release step authenticates via npx semantic-release with GITHUB_TOKEN/NODE_AUTH_TOKEN env vars, not the persisted git credential, and there's no other git push/git tag step relying on it. So this is a clean drop-in with no functional side effects.

Security: genuine, low-risk hardening fix — the standard, documented semantic-release recipe for this exact scenario.

Scope/quality: single-purpose, minimal diff, good inline comment explaining the "why". CHANGELOG entry included under Unreleased, appropriate for the change. No tests needed for a CI workflow config change.

Verdict: approve.

Reviewed SHA: 4cbd0d0

[asachs01]

Claude Code Review

Verdict: Approve

Correctness

Adds persist-credentials: false to the actions/checkout@v4 step in the release workflow — same well-established fix as the rest of this pattern-set. The release job's contents: write permission would otherwise leave a write-scoped git credential live in .git/config through npm ci, build and test. semantic-release authenticates via GITHUB_TOKEN directly, so this doesn't affect the release flow.

Security

Correctly remediates CWE-250. No new exposure introduced.

Code Quality

Inline comment matches the pattern used consistently across the other repos in this set — good consistency for reviewers auditing the whole batch.

Tests

N/A — CI config only, no application logic touched.

Docs

CHANGELOG.md updated with a clear entry under ## [Unreleased] / ### Changed.

Looks Good

Minimal, correct, well-documented security fix. Safe to merge.

[asachs01]

Hermes Agent Review

Verdict: Approve

Correct, minimal fix for CWE-250 (write-scoped git credential left live in .git/config through npm ci). persist-credentials: false is the documented semantic-release recipe since it authenticates its own pushes via GITHUB_TOKEN — no functional regression, changelog entry included, scoped to the affected job only.

Looks Good

• Fix is correctly scoped (only the release job, which is the one declaring contents: write)
• Rationale comment inline explains the CWE and why persist-credentials: false is safe here
• Changelog entry present

No blocking issues.

---

Reviewed by Hermes Agent