Skip to content

fix(deps): resolve js-yaml CVE-2026-84375 - #90

Merged
asachs01 merged 1 commit into
mainfrom
fix/js-yaml-advisory
Sep 15, 2026
Merged

asachs01 merged 1 commit into
mainfrom
fix/js-yaml-advisory

Conversation

@asachs01

@asachs01 asachs01 commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

Resolves the open HIGH Dependabot advisory GHSA-2883-xcg3-v3hh / CVE-2026-84375 for js-yaml (vulnerable range >= 4.0.0 < 4.3.2), clearing Vanta's High vulnerabilities test.

js-yaml is a dev-only transitive dependency pulled by cosmiconfig (via semantic-release). Applied a scoped npm override to force >= 4.3.2 (same pattern used in wyre-technology/afkbot):

"overrides": { "cosmiconfig": { "js-yaml": "^4.3.2" } }

Verification

  • npm audit: 0 vulnerabilities (js-yaml advisory gone)
  • js-yaml resolves to 4.3.2 in the lockfile
  • npm run build, npm run lint, npm run typecheck, and npm test all pass

Supersedes Dependabot PR #89 (bare lockfile bump) — the scoped override is self-documenting and prevents regression on re-resolution.

Closes advisory #48.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Chores
    • Updated dependency resolution to use a newer compatible version of the YAML parsing library.

Force js-yaml >= 4.3.2 via a scoped npm override on cosmiconfig
(the transitive parent(s) of js-yaml), clearing the HIGH advisory
GHSA-2883-xcg3-v3hh (CVE-2026-84375, vulnerable range >= 4.0.0 < 4.3.2).
js-yaml is a dev-only transitive dependency.

npm audit: 0 vulnerabilities. Build, lint, typecheck, and tests all pass.
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 2139886e-c64a-44ed-802c-54c0ee24f06d

📥 Commits

Reviewing files that changed from the base of the PR and between f57b661 and bb878cf.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json, !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The package configuration adds an npm override that pins cosmiconfig’s js-yaml dependency to ^4.3.2.

Changes

Dependency override

Layer / File(s) Summary
Pin cosmiconfig dependency
package.json
The npm configuration forces cosmiconfig to resolve js-yaml at version ^4.3.2.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to bb878

The change is limited to a scoped dependency override, with no unresolved production or workflow risk identified.

🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Changelog Entry ⚠️ Warning The PR adds an npm dependency override in package.json: cosmiconfig must resolve js-yaml to ^4.3.2. This changes package configuration. The PR also updates the lockfile from js-yaml 4.3.1 to… Add a corresponding entry beneath ## [Unreleased] in CHANGELOG.md. Place this entry in the Security section.
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the dependency fix and the specific js-yaml CVE addressed by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Changelog Entry

Explanation

The PR adds an npm dependency override in package.json: cosmiconfig must resolve js-yaml to ^4.3.2. This changes package configuration. The PR also updates the lockfile from js-yaml 4.3.1 to 4.3.2. CHANGELOG.md exists, but the authoritative diff has no changelog change and no ## [Unreleased] section. The change is a security fix for the stated CVE.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/js-yaml-advisory
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/js-yaml-advisory

Comment @coderabbitai help to get the list of available commands.

@asachs01
asachs01 merged commit a6d9584 into main Sep 15, 2026
4 checks passed
@asachs01
asachs01 deleted the fix/js-yaml-advisory branch September 15, 2026 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant