fix(ci): stop persisting a write-scoped git credential through npm ci

[wyre-agent-fleet]

Stops persisting a write-scoped git credential through npm ci (CWE-250).

The release job declares contents: write, which overrides this repo's
read-only default workflow permission — so actions/checkout's default
persisted credential was write-scoped and stayed live in .git/config
through dependency install, build and test, readable by any compromised
dependency lifecycle script during that window. persist-credentials: false
is semantic-release's own documented GitHub Actions recipe: it authenticates
its own pushes from GITHUB_TOKEN directly and never needed the persisted
credential.

Part of a pattern-set fix across WYRE-AI/node-*. Originally found and
fixed on 4 repos (node-spanning#46, node-domotz#48,
node-kaseya-quote-manager#16, node-alternative-payments#20), then a
propagation scope-check found the same pattern on 18 more repos. Full set
(18, this repo included) so reviewers can see membership:

node-axcient, node-blumira, node-clio, node-connectwise-cpq, node-datto-bcdr, node-datto-saas-protection, node-huntress, node-iqms, node-kaseya-bms, node-kaseya-vsa, node-mailprotector, node-mimecast, node-ncentral, node-proofpoint-essentials, node-rootly, node-scalepad, node-threatlocker, node-unitrends

Generated by warden's Gate-3 CWE-250 review, per boss's set-completeness ruling.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 362a886c-8a06-474f-b1d7-a70ad346bd1c

📥 Commits

Reviewing files that changed from the base of the PR and between eaaefa4 and 0e79228.

📒 Files selected for processing (2)

• .github/workflows/release.yml
• CHANGELOG.md

---

_{Comment @coderabbitai help to get the list of available commands.}

[wyre-agent-fleet]

Peer review (comment-only, per the shared-identity self-approval gate).

Verdict: approve, no blockers.

Verified independently against the actual diff content (not just warden's filing summary), as part of the 18-PR CWE-250 follow-up set-review:

• release.yml: adds persist-credentials: false to the release job's actions/checkout step, with the same explanatory comment across all 18 PRs (CWE-250: the release job's contents: write permission makes checkout's default persisted credential write-scoped and live in .git/config through npm ci; persist-credentials: false is semantic-release's own documented recipe since it authenticates pushes via GITHUB_TOKEN directly). The core fix content is byte-identical across the batch -- raw diff size varies only where a repo's pre-existing checkout step used a different YAML style (inline vs multi-line map).
• CHANGELOG.md: entry added under this repo's existing Unreleased section, correct per this repo's own convention.
• No unrelated files touched -- scope is clean.

Full batch (all independently verified): node-axcient#2, node-blumira#41, node-clio#2, node-connectwise-cpq#2, node-datto-bcdr#55, node-datto-saas-protection#55, node-huntress#43, node-iqms#39, node-kaseya-bms#48, node-kaseya-vsa#50, node-mailprotector#2, node-mimecast#44, node-ncentral#4, node-proofpoint-essentials#1, node-rootly#27, node-scalepad#2, node-threatlocker#31, node-unitrends#51

[asachs01]

Review: stop persisting write-scoped git credential through npm ci

Verified fix is correct and matches the described issue:

• Release job grants contents: write, which upgrades the default actions/checkout credential to write-scoped and (without this fix) that credential stays live in .git/config through npm ci/build/test — exposed to any compromised dependency lifecycle script (CWE-250).
• persist-credentials: false is the correct, minimal mitigation and matches semantic-release's own documented recipe, since semantic-release authenticates pushes via GITHUB_TOKEN directly and never reads the persisted credential.
• Diff is scoped to the actions/checkout step only — no unrelated changes, no regressions to the release/publish flow.

Security: no new secrets, no injection surface; this closes a credential-exposure window rather than opening one.

Docs: CHANGELOG.md entry accurately describes the change.

Tests: none needed — CI workflow config change, verified by inspection.

Approving.

[asachs01]

Code Review Summary — Claude Code

Verdict: Approve

Critical

None

Warnings

None

Suggestions

• Consider confirming no other step in the release job (or a later job) relies on the persisted git credential for something other than the semanticRelease push (e.g. tagging via plain git push, submodules). The comment correctly documents that semantic-release authenticates via GITHUB_TOKEN directly, but a quick grep of the job for git push/git tag outside semantic-release confirms this is safe — worth a one-line sanity check before merge if not already done.
• fetch-depth: 0 is retained, which is appropriate since persist-credentials: false does not affect fetch depth.

Looks Good

• Root-caused correctly: contents: write permission on the release job upgrades the default checkout credential to write-scope, which then sits in .git/config through npm ci/build/test — a real supply-chain exposure (CWE-250 is the right classification).
• Fix is minimal, targeted, and matches the semantic-release project's own documented recipe for this exact scenario.
• CHANGELOG entry is clear, accurate, and added to the correct (Unreleased) section without disturbing the semantic-release-generated entries below it.
• No behavior change to the actual release/publish flow — GITHUB_TOKEN continues to be used by semantic-release for pushes, so this is a security hardening with no functional regression.

[asachs01]

Reviewed by Claude Code. Adds persist-credentials: false to the release job's checkout step, eliminating the write-scoped git credential (from contents: write) that otherwise stayed live in .git/config through npm ci/build/test; semantic-release already authenticates via GITHUB_TOKEN directly, so no needed auth is removed. CHANGELOG updated accordingly.

[asachs01]

Code Review Summary (Reviewed by Hermes Agent)

Looks Good

• Correctly identifies the gap: the release job's contents: write permission overrides the repo default, so actions/checkout's persisted credential is write-scoped and remains on disk through npm ci/build/test — exploitable by a compromised dependency lifecycle script (CWE-250).
• persist-credentials: false is the right, minimal fix and matches semantic-release's own documented recipe (it authenticates pushes via GITHUB_TOKEN directly, not the persisted git credential).
• Change is scoped to the checkout step only; no functional/build behavior affected.
• CHANGELOG entry documents the change clearly for downstream consumers.

Suggestions

• Consider adding this as a lint/policy check (e.g. a repo-wide CI guard) across the org's other release workflows so the pattern doesn't need to be reintroduced PR-by-PR per repo.

No security regressions introduced; fix closes the stated gap.

[asachs01]

Reviewed against the verified fleet-wide fix pattern: this diff adds persist-credentials: false to the actions/checkout step in .github/workflows/release.yml (with matching CHANGELOG entry), preventing the write-scoped git credential from persisting through npm ci in the release job (CWE-250). semantic-release authenticates its own pushes via GITHUB_TOKEN directly, so this credential was unnecessary and its removal introduces no functional regression. Matches the pattern confirmed in WYRE-AI/node-unitrends#51. Approved.

Reviewed by Hermes Agent

[asachs01]

Review — headRefOid 0e792281e41b9e532a12eb975756e64353d998b3

Single-purpose CI fix: adds persist-credentials: false to the release job's actions/checkout step, plus a matching CHANGELOG entry.

Critical: None.

Warnings: None. The fix is correct — the release job declares contents: write, which overrides the repo's default read-only workflow permission, so the checkout step's default persisted credential is write-scoped and stays on disk through npm ci/build/test. Disabling persistence is the right mitigation (CWE-250) since semantic-release authenticates its own push from GITHUB_TOKEN, not the persisted git credential.

Suggestions: None — minimal, scoped diff; low risk.

Looks Good: Change is limited to the workflow YAML comment/flag and a changelog line; no application code touched; consistent with the same fix already applied/reviewed across the sibling node-* repos in this pattern-set.

Verdict: Comment only (already approved by reviewer; no blocking issues).

[asachs01]

Reviewed via automated sweep.

Correctness: The fix is sound. contents: write on the release job escalates actions/checkout's default persisted credential to write-scope, and it otherwise stays live in .git/config for the duration of npm ci/build/test — readable by any compromised dependency install/lifecycle script (classic CWE-250 exposure). Adding persist-credentials: false closes that window.

Verified no regression: checked the full release.yml — the release step authenticates via npx semantic-release with GITHUB_TOKEN/NODE_AUTH_TOKEN env vars, not the persisted git credential, and there's no other git push/git tag step relying on it. So this is a clean drop-in with no functional side effects.

Security: genuine, low-risk hardening fix — the standard, documented semantic-release recipe for this exact scenario.

Scope/quality: single-purpose, minimal diff, good inline comment explaining the "why". CHANGELOG entry included, appropriate for the change. No tests needed for a CI workflow config change.

Verdict: approve.

Reviewed SHA: 0e79228

[asachs01]

Claude Code Review

Verdict: Approve

Correctness

Adds persist-credentials: false to the actions/checkout@v4 step in the release workflow. Correctly closes the exposure window: the release job's contents: write permission makes the default persisted checkout credential write-scoped through npm ci/build/test, and semantic-release doesn't need it since it pushes via GITHUB_TOKEN directly.

Security

Correct, targeted fix for CWE-250 (unnecessary credential persistence/exposure).

Code Quality

Consistent with the other repos in this pattern-set — same inline rationale comment, easy to audit across the batch.

Tests

N/A — CI workflow change only.

Docs

CHANGELOG.md updated under ### Added with an appropriate, clear entry.

Looks Good

Clean, minimal, well-justified fix. Safe to merge.

[asachs01]

Hermes Agent Review

Verdict: Approve

Correct, minimal fix for CWE-250 (write-scoped git credential left live in .git/config through npm ci). persist-credentials: false is the documented semantic-release recipe since it authenticates its own pushes via GITHUB_TOKEN — no functional regression, changelog entry included, scoped to the affected job only.

Looks Good

• Fix is correctly scoped (only the release job, which is the one declaring contents: write)
• Rationale comment inline explains the CWE and why persist-credentials: false is safe here
• Changelog entry present

No blocking issues.

---

Reviewed by Hermes Agent