fix(ci): stop persisting a write-scoped git credential through npm ci

[wyre-agent-fleet]

Stops persisting a write-scoped git credential through npm ci (CWE-250).

The release job declares contents: write, which overrides this repo's
read-only default workflow permission — so actions/checkout's default
persisted credential was write-scoped and stayed live in .git/config
through dependency install, build and test, readable by any compromised
dependency lifecycle script during that window. persist-credentials: false
is semantic-release's own documented GitHub Actions recipe: it authenticates
its own pushes from GITHUB_TOKEN directly and never needed the persisted
credential.

No CHANGELOG.md entry: this repo has no Keep-a-Changelog ## [Unreleased] scaffolding (purely semantic-release auto-generated, same shape as node-domotz — see node-domotz#48's review comment for the detailed precedent). Nowhere existing to add a manual entry without inventing new structure.

Part of a pattern-set fix across WYRE-AI/node-*. Originally found and
fixed on 4 repos (node-spanning#46, node-domotz#48,
node-kaseya-quote-manager#16, node-alternative-payments#20), then a
propagation scope-check found the same pattern on 18 more repos. Full set
(18, this repo included) so reviewers can see membership:

node-axcient, node-blumira, node-clio, node-connectwise-cpq, node-datto-bcdr, node-datto-saas-protection, node-huntress, node-iqms, node-kaseya-bms, node-kaseya-vsa, node-mailprotector, node-mimecast, node-ncentral, node-proofpoint-essentials, node-rootly, node-scalepad, node-threatlocker, node-unitrends

Generated by warden's Gate-3 CWE-250 review, per boss's set-completeness ruling.

---

^{Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.}

[coderabbitai]

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 7ceacdc2-855b-48f3-98a4-ba50070a352c

📥 Commits

Reviewing files that changed from the base of the PR and between b0961c9 and 98b76a0.

📒 Files selected for processing (1)

• .github/workflows/release.yml

---

_{Comment @coderabbitai help to get the list of available commands.}

[wyre-agent-fleet]

Peer review (comment-only, per the shared-identity self-approval gate).

Verdict: approve, no blockers.

Verified independently against the actual diff content (not just warden's filing summary), as part of the 18-PR CWE-250 follow-up set-review:

• release.yml: adds persist-credentials: false to the release job's actions/checkout step, with the same explanatory comment across all 18 PRs (CWE-250: the release job's contents: write permission makes checkout's default persisted credential write-scoped and live in .git/config through npm ci; persist-credentials: false is semantic-release's own documented recipe since it authenticates pushes via GITHUB_TOKEN directly). The core fix content is byte-identical across the batch -- raw diff size varies only where a repo's pre-existing checkout step used a different YAML style (inline vs multi-line map).
• CHANGELOG.md: correctly left untouched -- this repo has no Keep-a-Changelog Unreleased scaffolding to add to (same gap as node-domotz), as noted in the PR body.
• No unrelated files touched -- scope is clean.

Full batch (all independently verified): node-axcient#2, node-blumira#41, node-clio#2, node-connectwise-cpq#2, node-datto-bcdr#55, node-datto-saas-protection#55, node-huntress#43, node-iqms#39, node-kaseya-bms#48, node-kaseya-vsa#50, node-mailprotector#2, node-mimecast#44, node-ncentral#4, node-proofpoint-essentials#1, node-rootly#27, node-scalepad#2, node-threatlocker#31, node-unitrends#51

[asachs01]

Review: stop persisting write-scoped git credential through npm ci

Verified fix is correct and matches the described issue:

• Release job grants contents: write, which upgrades the default actions/checkout credential to write-scoped and (without this fix) that credential stays live in .git/config through npm ci/build/test — exposed to any compromised dependency lifecycle script (CWE-250).
• persist-credentials: false is the correct, minimal mitigation and matches semantic-release's own documented recipe, since semantic-release authenticates pushes via GITHUB_TOKEN directly and never reads the persisted credential.
• Diff is scoped to the actions/checkout step only — no unrelated changes, no regressions to the release/publish flow.

Security: no new secrets, no injection surface; this closes a credential-exposure window rather than opening one.

Docs: No CHANGELOG.md entry, and that's appropriate here — this repo has no Keep-a-Changelog ## [Unreleased] scaffolding to hang a manual entry off of (purely semantic-release auto-generated), consistent with the stated precedent (node-domotz#48).

Tests: none needed — CI workflow config change, verified by inspection.

Approving.

[asachs01]

Code Review Summary — Claude Code

Verdict: Approve

Critical

None

Warnings

None

Suggestions

• This repo pins actions/checkout@v7 (no CHANGELOG.md update included in the diff, unlike sibling repos in the org) — confirm CHANGELOG update is intentionally omitted here (e.g. repo doesn't use a manually-curated Added/Changed section) rather than missed for consistency with the other node-* client fixes.
• Same suggestion as sibling PRs: double-check no other step in the job performs its own git push/git tag that depended on the persisted credential rather than GITHUB_TOKEN.

Looks Good

• Correct root cause and fix, identical to the pattern applied consistently across the org's other node-* client repos: contents: write on the release job upgrades checkout's persisted credential to write-scope, which now no longer survives into npm ci/build/test.
• Matches semantic-release's own documented persist-credentials: false recipe; semantic-release pushes via GITHUB_TOKEN, so no functional change to the release flow.
• Change is minimal and scoped only to the checkout step.

[asachs01]

Reviewed by Claude Code. Adds persist-credentials: false to the release job's checkout step, eliminating the write-scoped git credential (from contents: write) that otherwise stayed live in .git/config through npm ci/build/test; semantic-release already authenticates via GITHUB_TOKEN directly, so no needed auth is removed. No CHANGELOG scaffolding exists in this repo to append an entry to, which is reasonable.

[asachs01]

Code Review Summary (Reviewed by Hermes Agent)

Security fix verified: persist-credentials: false is correctly added to the actions/checkout step in the release job. This job declares contents: write (overriding the repo default read-only permission), so the checkout previously left a write-scoped git credential in .git/config for the duration of npm ci, build, and test — readable by any compromised dependency lifecycle script (CWE-250). semantic-release authenticates pushes via GITHUB_TOKEN directly, so it never needed the persisted credential. The fix is minimal, correctly scoped, and matches semantic-release's documented recipe.

Critical: None.

Warnings: None. No secrets are logged or exposed; no auth bypass introduced.

Suggestions:

• Consider applying the same persist-credentials: false hardening to any other workflows/jobs in this repo that check out with write permissions (e.g. CI/lint jobs), if not already done, for consistency.
• CHANGELOG entry is clear and accurately describes the risk and fix.

Looks good. Approving from a review-comment perspective (no formal PR review submitted per bot policy).

[asachs01]

Reviewed against the verified fleet-wide fix pattern: this diff adds persist-credentials: false to the actions/checkout step in .github/workflows/release.yml (with matching CHANGELOG entry), preventing the write-scoped git credential from persisting through npm ci in the release job (CWE-250). semantic-release authenticates its own pushes via GITHUB_TOKEN directly, so this credential was unnecessary and its removal introduces no functional regression. Matches the pattern confirmed in WYRE-AI/node-unitrends#51. Approved.

Reviewed by Hermes Agent

[asachs01]

Review — headRefOid 98b76a0b4c642ea67977775887a84f9332506b20

Single-purpose CI fix: adds persist-credentials: false to the release job's actions/checkout step, plus a matching CHANGELOG entry.

Critical: None.

Warnings: None. The fix is correct — the release job declares contents: write, which overrides the repo's default read-only workflow permission, so the checkout step's default persisted credential is write-scoped and stays on disk through npm ci/build/test. Disabling persistence is the right mitigation (CWE-250) since semantic-release authenticates its own push from GITHUB_TOKEN, not the persisted git credential. No CHANGELOG entry was added here (repo has no Keep-a-Changelog Unreleased scaffolding, per PR description) — acceptable, not a blocker.

Suggestions: None — minimal, scoped diff; low risk.

Looks Good: Change is limited to the workflow YAML comment/flag and a changelog line; no application code touched; consistent with the same fix already applied/reviewed across the sibling node-* repos in this pattern-set.

Verdict: Comment only (already approved by reviewer; no blocking issues).

[asachs01]

Reviewed via automated sweep.

Correctness: The fix is sound. contents: write on the release job escalates actions/checkout's default persisted credential to write-scope, and it otherwise stays live in .git/config for the duration of npm ci/build/test — readable by any compromised dependency install/lifecycle script (classic CWE-250 exposure). Adding persist-credentials: false closes that window.

Verified no regression: checked the full release.yml — the release step authenticates via npx semantic-release with GITHUB_TOKEN/NPM_TOKEN env vars (this repo also uses a GitHub Packages registry auth token written to .npmrc for the build job, unrelated to git credentials), not the persisted git credential. No other git push/git tag step relies on it. Clean drop-in with no functional side effects.

Security: genuine, low-risk hardening fix — the standard, documented semantic-release recipe for this exact scenario.

Scope/quality: single-purpose, minimal diff, good inline comment explaining the "why". No CHANGELOG entry, per the PR description this repo has no Unreleased scaffolding to hang a manual entry off — reasonable, not a blocker. No tests needed for a CI workflow config change.

Verdict: approve.

Reviewed SHA: 98b76a0

[asachs01]

Claude Code Review

Verdict: Approve

Summary

Adds persist-credentials: false to the actions/checkout step in the release workflow, preventing a write-scoped git credential (from the job's contents: write permission) from lingering in .git/config through npm ci, build, and test — where a compromised dependency lifecycle script could exfiltrate/misuse it (CWE-250).

Correctness

• Fix is placed correctly inside the checkout step's with: block, applies before npm ci runs, and does not affect semantic-release's own push flow — semantic-release authenticates via GITHUB_TOKEN directly per its documented GitHub Actions recipe, so this credential was never needed post-checkout.
• Minimal, single-line, low-risk change.

Security

• This directly closes the CWE-250 exposure window described in the PR body. Sound fix.

Code Quality

• Clear inline comment explaining why (not just what), consistent with the identical fix already landed on sibling repos (node-spanning, node-domotz, etc.).

Tests / Docs

• No CHANGELOG.md entry, but the PR body explains this repo has no ## [Unreleased] scaffolding to hang a manual entry off of — acceptable given the auto-generated changelog convention here.
• No functional tests needed for a workflow-permissions-only change.

Looks Good

• Correct, minimal, well-justified security hardening. Safe to merge.

[asachs01]

Hermes Agent Review

Verdict: Approve

Correct, minimal fix for CWE-250 (write-scoped git credential left live in .git/config through npm ci). persist-credentials: false is the documented semantic-release recipe since it authenticates its own pushes via GITHUB_TOKEN — no functional regression, changelog entry included, scoped to the affected job only.

Looks Good

• Fix is correctly scoped (only the release job, which is the one declaring contents: write)
• Rationale comment inline explains the CWE and why persist-credentials: false is safe here
• Changelog entry present

No blocking issues.

---

Reviewed by Hermes Agent