Conversation
…, not just bare PR#N unverified_external_ref only pattern-matched bare "PR #N" mentions. A full github.com/<owner>/<repo>/pull/<n> URL for the same PR names the repo explicitly -- nothing left to verify -- but was invisible to the checker, so a task carrying both forms (a bare mention plus the resolving URL alongside it) kept re-flagging on every scan. Adds GITHUB_PR_URL_REGEX and skips a bare "PR #N" match when a full URL for the same number appears anywhere in the same task text (title + description), in addition to the existing precedent-citation check. Verified against the two live examples in task_1788535091729's own bug report: task_1788446092100_21920670 (PR #170) genuinely has a full URL in its description and will stop re-flagging. task_1788464546954_33593143 (PR #172) does NOT -- it only ever names the repo via a parenthetical "PR #172 (WYRE-AI/cortextos)" annotation, never a URL, so it is unaffected by this fix. Scoped deliberately to what was asked (URL recognition) -- the parenthetical-repo-name shape is a real, different pattern worth its own follow-up task, not folded in here. Deliberately does NOT touch the separate "already manually superseded" mechanism (murph's mimecast-mcp PR #3 case, task_1779287346080_74441757) -- that citation has no full URL either, so this fix doesn't help it. It needs the same kind of scrutiny the existing dismissal-marker convention (task_1788305871620_29811457, same file, already fragile with a known 8-case regression matrix and two rejected fix attempts) already applies to "tool artifact" markers, not a second bolt-on mechanism. Left as an open question for that task's owner rather than expanding this PR's blast radius into already-fragile negation-scoping code. --- Task-ID: task_1788535091729_35071329 Agent: dev Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unverified_external_refonly pattern-matched bare "PR #N" mentions. A fullgithub.com/<owner>/<repo>/pull/<n>URL for the same PR names the repo explicitly — nothing left to verify — but was invisible to the checker, so a task carrying both forms kept re-flagging on every scan (4th confirmed recurrence today, task_1788535091729_35071329).GITHUB_PR_URL_REGEX; skips a bare "PR #N" match when a full URL for the same number appears anywhere in the same task text.task_1788446092100_21920670(PR fix(kb): retry-with-backoff on embed_content, fixing intra-file 429 bursts #170): has a real full URL, will stop re-flagging. ✅task_1788464546954_33593143(PR docs(agent-template): sync 429 retry rule v2 into shared HEARTBEAT.md template #172): only ever names the repo viaPR #172 (WYRE-AI/cortextos)— a parenthetical, not a URL — so it's unaffected by this fix. That's a real, different pattern worth its own follow-up task, deliberately not folded in here (stayed scoped to what was asked).task_1788305871620_29811457, same file — already fragile, 8-case regression matrix, two rejected fix attempts). Left as an open question for that task rather than expanding this PR into already-fragile negation-scoping code.Test plan
npm run typecheck— cleannpx vitest run tests/unit/bus/system.test.ts— 45/45 passing (3 new: URL-resolves-bare-mention, URL-for-different-number-still-flags, URL-only-no-bare-form-not-flagged)npx vitest run tests/unit/bus/— 434/434 passing, no regressionsTask-ID: task_1788535091729_35071329
Agent: dev
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.