ci: merge unit-tests into lint-typecheck job#160
Open
jakebromberg wants to merge 1 commit intoci/skip-redundant-buildfrom
Open
ci: merge unit-tests into lint-typecheck job#160jakebromberg wants to merge 1 commit intoci/skip-redundant-buildfrom
jakebromberg wants to merge 1 commit intoci/skip-redundant-buildfrom
Conversation
The standalone unit-tests job duplicated runner setup (checkout, Node, cache, npm ci) for just 4 seconds of test execution. Merge it into the lint-and-typecheck job which already has all dependencies installed and built. This eliminates one runner spin-up (~30s) per CI run.
jakebromberg
force-pushed
the
ci/merge-unit-tests-job
branch
from
f94926f to
297b192
Compare
jakebromberg
force-pushed
the
ci/skip-redundant-build
branch
from
ad7d257 to
b7d973a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unit-testsjob intolint-and-typecheck, renamed tolint-typecheck-and-unit-testsnpm cifor just ~4 seconds of test executionIntegration-Testsjob dependency updated to reference the renamed jobEstimated savings
~30 seconds per CI run (one fewer runner spin-up)
Test plan
Integration-Testsstill runs after the combined job passes--changedSinceflag still works correctly for PRsworkflow_dispatchruns the full unit test suite