feat: add V2 paginated flowsheet endpoint#155
Open
jakebromberg wants to merge 2 commits intorefactor/rename-play-freq-to-rotation-binfrom
Open
feat: add V2 paginated flowsheet endpoint#155jakebromberg wants to merge 2 commits intorefactor/rename-play-freq-to-rotation-binfrom
jakebromberg wants to merge 2 commits intorefactor/rename-play-freq-to-rotation-binfrom
Conversation
added 2 commits
February 13, 2026 14:37
Rename the rotation table column from play_freq to rotation_bin to align with api.yaml naming conventions. Includes a manual SQL migration that drops and recreates library_artist_view and rotation_library_view since they reference the renamed column. Updates all source files, types, tests, and seed data.
Add paginated GET /v2/flowsheet/ and GET /v2/flowsheet/latest endpoints returning discriminated union entries with pre-parsed fields. Extract getShowMetadata from getPlaylist to avoid redundant entry fetches in the V2 controller. Add unit tests for V2 controller handlers covering pagination logic, input validation, error handling, and show info endpoint.
4f3d45f to
ea1c39c
Compare
0663daa to
6d0e713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /v2/flowsheet/andGET /v2/flowsheet/latestendpoints returning discriminated union entriesgetShowMetadatafromgetPlaylistto avoid redundant entry fetchesShowMetadatatype andgetEntryCountfor pagination supportStacked on #154 (rename play_freq to rotation_bin).
Review fixes applied
totalPagesresponse field matches api.yaml (wastotal_pages)entry_type: stringshadow onIFSEntry(inherits typed enum fromFSEntry)app.yamlrename changes to PR refactor: rename play_freq to rotation_bin #154jest.clearAllMocks()in testbeforeEachTest plan