Skip to content

feat: implement livebook for exercises#7

Open
SadeQL wants to merge 3 commits into
mainfrom
feat-first-trial-of-livebook-implementation
Open

feat: implement livebook for exercises#7
SadeQL wants to merge 3 commits into
mainfrom
feat-first-trial-of-livebook-implementation

Conversation

@SadeQL

@SadeQL SadeQL commented Jan 25, 2023

Copy link
Copy Markdown

This PR changes several stuff:

  • Rename Level to Section to avoid some misunderstandings (like need to finish level 1, which is beginner level before jumping into the next level).
  • Implement 2 exercises on Livebook for the first section. This needs to be discussed and enriched in a near future.

The livebook password is written directly on the md file. Is it necessary to have a .env for that, since everything should be public?

The cons of that is everyone having access of the livebook can edit everything.

@SadeQL SadeQL requested a review from scollon42 January 25, 2023 15:39

@scollon42 scollon42 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to host some .livemd files in the repository and then to offer the possibility to open it with liveview (with this feature : https://livebook.dev/badge).

We would need to make the repository public, but in my opinion, it would make sense (event without communicating on it)

@SadeQL

SadeQL commented Jan 26, 2023

Copy link
Copy Markdown
Author

Yeah good idea. I'll check how that works. For now the badge only generates a button that redirects to the livebook.

@scollon42

Copy link
Copy Markdown
Contributor

Yeah good idea. I'll check how that works. For now the badge only generates a button that redirects to the livebook.

Yeah, but It allow you to choose between running it locally (and provide detailled steps to install livebook) or to run it with fly.io 👍

@SadeQL

SadeQL commented Jan 26, 2023

Copy link
Copy Markdown
Author

Yeah good idea. I'll check how that works. For now the badge only generates a button that redirects to the livebook.

Yeah, but It allow you to choose between running it locally (and provide detailled steps to install livebook) or to run it with fly.io 👍

True! I changed it to a badge. It might be interesting to take a moment during backend chapters to talk about relevant exercises to put in this learning path.

@SadeQL SadeQL force-pushed the feat-first-trial-of-livebook-implementation branch from 3659ac5 to a1d5a77 Compare January 26, 2023 08:59
@scollon42

Copy link
Copy Markdown
Contributor

Great! Can you also add the code from your livebook into your PR ? (in a livemd file ?)

@SadeQL

SadeQL commented Jan 26, 2023

Copy link
Copy Markdown
Author

Great! Can you also add the code from your livebook into your PR ? (in a livemd file ?)

Done! It's within a exercises folder as there are 3 sections. I think it'd be clearer organizing this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants