Skip to content

Comments

fix(Idea Summary): Only show ideas and sample responses for the current period#2275

Merged
hirokiterashima merged 2 commits intodevelopfrom
idea-summary-only-show-period-ideas
Feb 24, 2026
Merged

fix(Idea Summary): Only show ideas and sample responses for the current period#2275
hirokiterashima merged 2 commits intodevelopfrom
idea-summary-only-show-period-ideas

Conversation

@hirokiterashima
Copy link
Member

Changes

  • Only show sample responses for the currently-selected period for Open Response items with idea detection
  • Only show ideas for the currently-selected period

Test

  • Changes above work as described

@hirokiterashima hirokiterashima self-assigned this Feb 23, 2026
@hirokiterashima hirokiterashima added the bug Something isn't working label Feb 23, 2026
@qltysh
Copy link

qltysh bot commented Feb 23, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (2)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...mmary-display/ideas-summary-display/ideas-summary.component.ts100.0%
New file Coverage rating: D
...teacher-summary-display/idea-summary/idea-summary.component.ts75.0%36-39
Total76.9%
🤖 Increase coverage with AI coding...

In the `idea-summary-only-show-period-ideas` branch, add test coverage for this new code:

- `src/assets/wise5/directives/teacher-summary-display/idea-summary/idea-summary.component.ts` -- Line 36-39

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review February 24, 2026 00:22
@hirokiterashima hirokiterashima merged commit fa0b9a6 into develop Feb 24, 2026
4 checks passed
@hirokiterashima hirokiterashima deleted the idea-summary-only-show-period-ideas branch February 24, 2026 00:22
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.210.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant