Skip to content

Comments

feat(IdeasDetected): Hide ideas that are not in the rubric#2271

Merged
hirokiterashima merged 7 commits intodevelopfrom
hide-ideas-not-in-rubric-from-ideas-detected
Feb 23, 2026
Merged

feat(IdeasDetected): Hide ideas that are not in the rubric#2271
hirokiterashima merged 7 commits intodevelopfrom
hide-ideas-not-in-rubric-from-ideas-detected

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Feb 20, 2026

Changes

  • Don't show ideas that are not in the rubric from the following places:
    • Match imported ideas from Dialog Guidance (student vle)
    • Idea summary display (teacher tools)
    • Detected ideas for student responses (teacher tools)
  • Refactor surrounding code for clarity
  • Fix typo: ideaSummaryGroups -> ideasSummaryGroups

Test

  • Ideas that are not in the rubric should not appear in:
    • Match imported ideas from Dialog Guidance (student vle)
    • Idea summary display (teacher tools)
    • Detected ideas for student responses (teacher tools)
  • Idea summary display (teacher tools) still works and looks as before. I refactored code that the feature is using

@hirokiterashima hirokiterashima self-assigned this Feb 20, 2026
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Feb 20, 2026
@qltysh
Copy link

qltysh bot commented Feb 20, 2026

Qlty

Coverage Impact

Unable to calculate total coverage change because base branch coverage was not found.

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
New file Coverage rating: A
...tives/teacher-summary-display/summary-data/IdeasSummaryData.ts66.7%32
New file Coverage rating: B
...pen-response-advanced/edit-open-response-advanced.component.ts100.0%
New file Coverage rating: A
...ents/dialogGuidance/detected-ideas/detected-ideas.component.ts100.0%
New file Coverage rating: A
src/assets/wise5/components/common/cRater/CRaterRubric.ts100.0%
Total93.3%
🤖 Increase coverage with AI coding...

In the `hide-ideas-not-in-rubric-from-ideas-detected` branch, add test coverage for this new code:

- `src/assets/wise5/directives/teacher-summary-display/summary-data/IdeasSummaryData.ts` -- Line 32

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@hirokiterashima hirokiterashima marked this pull request as ready for review February 20, 2026 22:33
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@hirokiterashima hirokiterashima merged commit 341299d into develop Feb 23, 2026
1 check passed
@hirokiterashima hirokiterashima deleted the hide-ideas-not-in-rubric-from-ideas-detected branch February 23, 2026 22:33
@hirokiterashima
Copy link
Member Author

🎉 This PR is included in version 5.210.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature of any size or improvement (UI, performance, security) released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants