Skip to content

Fix desktop: stray lines at the top of revision.js - #463

Merged
WARR-eV merged 2 commits into
mainfrom
fix-desktop-revision-syntax
Nov 22, 2026
Merged

WARR-eV merged 2 commits into
mainfrom
fix-desktop-revision-syntax

Conversation

@rudalabs

Copy link
Copy Markdown
Collaborator

The desktop UI (JavaScript syntax) check fails on main (f35a131): desktop/ui/js/revision.js began with three lines of its own data block (requests, propertyMismatches) above the licence header – left by a merge – so the module did not parse (SyntaxError: Unexpected token ':' at line 3). Besides the red check, the Revision tab of the desktop app could not load. The three lines are removed; the real ones further down are complete.

Checked: no other desktop/shared script lacks its header line, and no conflict markers are left in the UI files. CHANGELOG entry.

🤖 Generated with Claude Code

rudalabs and others added 2 commits November 22, 2026 23:21
index 9b2e348..3bca46f 100755
--- a/desktop/ui/js/revision.js
+++ b/desktop/ui/js/revision.js
@@ -1,6 +1,3 @@
-      requests: r[0].open_requests || [],
-      // design properties that differ from the revision (#367; older servers: none)
-      propertyMismatches: r[0].property_mismatches || [],
 // SPDX-License-Identifier: MPL-2.0
 // TeamCraft Desktop – Revision tab: overview, files, structure, where used.
 // Part of the desktop UI (ES modules, no build step; js/main.js starts it).
desktop/ui/js/revision.js began with three lines of its own data block
(requests, propertyMismatches) above the licence header, left by a
merge; the module did not parse, so the Revision tab could not load and
the desktop UI syntax check failed on main (f35a131). The real lines
further down are complete.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@WARR-eV
WARR-eV merged commit c2a7f86 into main Nov 22, 2026
6 checks passed
@WARR-eV
WARR-eV deleted the fix-desktop-revision-syntax branch November 22, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants