Repository navigation
Request ids on every answer and key inputs in desktop problem reports (#381) - #443
Merged
Merged
Conversation
…#381) Server: every answer carries an x-request-id header (a new UUID, or a valid incoming id of 1-64 characters [A-Za-z0-9-]); the request's trace span records it as request_id, and the web error pages show it under "Details for a bug report" and in Copy details. Unit tests in lib.rs, an end-to-end test in tests/request_id.rs. Desktop: run(), toast() and dialog() take the key inputs of an action (desktop/ui/js/report-inputs.js: names and short values only, paths reduced to the file name, at most 12 values of 200 characters), filled for check-out, check-in/park, get, open, 3D preview and STL export, STEP export, new item, add files, BOM and folder import, request attachments. A failed 3D preview now also shows an error toast with Report... Tested by scripts/desktop-report-inputs.test.mjs (CI job ui). Docs: CHANGELOG, README, desktop/README, guide/desktop.md, admin/operations.md, reference/api.md, dev/threat-model.md, OPEN_WORK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- 3D preview: toast a failed mesh download only while that viewer is still shown - CHANGELOG: narrow the claim to previews that cannot be loaded from the server - OPEN_WORK: list inline error notices without *Report…* as left work - CLAUDE.md: request ids in the src/lib.rs line of the Architecture map Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sebagrei
marked this pull request as ready for review
November 22, 2026 20:50
…d-report-inputs # Conflicts: # CHANGELOG.md # desktop/README.md # desktop/ui/js/workspace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #381 – the request id and the key inputs; screenshot and affected-file attachments stay open (pending a decision, listed in
docs/OPEN_WORK.md).What changed
Server – request ids
src/lib.rs(assign_request_id, outermost layer): every answer gets anx-request-idheader – a new UUID, or a valid incoming id (1–64 characters of[A-Za-z0-9-], e.g. from a reverse proxy). The id is stored in the request extensions (RequestId) and recorded asrequest_idin thehttptrace span.src/web/mod.rspasses it to the error page;templates/error.htmlshowsRequest id: …in Details for a bug report (and so in Copy details). JSON error bodies are unchanged (header only).only_short_plain_request_ids_are_taken_over,every_response_carries_the_request_id(lib.rs), theerror.htmlrender case insrc/templates.rs, andtests/request_id.rs(error page and header carry the same id; proxy id kept, invalid id replaced; API and healthz carry the header).Desktop – key inputs per action
desktop/ui/js/report-inputs.js(reportInputs,revisionInputs,failureOf): names and short values only, paths reduced to the file name, empty values dropped, at most 12 values of 200 characters (the caps ofdesktop/src/report.rs, checked by the test).run(statusText, fn, inputs),toast(text, kind, action, inputs)anddialog(…, { inputs })incore.jspass the inputs (a list or a function evaluated when the error is shown) to Report….scripts/desktop-report-inputs.test.mjs(new CI step indesktop.yml, jobui);scripts/ci-changes.shruns the ui job whendesktop/src/report.rschanges (self-test passes).Docs:
CHANGELOG.md,README.md,desktop/README.md,docs/src/guide/desktop.md,docs/src/admin/operations.md(new Request ids section),docs/src/reference/api.md(x-request-id),docs/src/dev/threat-model.md(new row: forged request ids; report row updated),docs/OPEN_WORK.md.How it was tested
Not compiled or run locally (no builds on this machine by rule; no Node.js available either) – CI verifies build, clippy, the Rust tests and the Node test.
cargo fmt --allwas run andscripts/ci-changes.sh --self-testpasses.Checklist
knowledge), or openly licensed material under a compatible licence
that is credited. It contains no code decompiled, disassembled or
rewritten from proprietary software and no leaked code
(CONTRIBUTING.md).
CHANGELOG.md,README.md,docs/src/**,docs/OPEN_WORK.mdwhere it applies).cargo fmt --all --check,cargo clippy --all-targets -- -D warningsand
cargo testpass locally, or CI runs them. (fmt run locally; clippy and tests: CI)🤖 Generated with Claude Code