Skip to content

fix(voice): OAS spec parity — style type, PhoneEndpoint.onAnswer, WebSocket content-type serialization#1071

Draft
Copilot wants to merge 4 commits into
mainfrom
copilot/check-feature-parity-vonage-voice
Draft

fix(voice): OAS spec parity — style type, PhoneEndpoint.onAnswer, WebSocket content-type serialization#1071
Copilot wants to merge 4 commits into
mainfrom
copilot/check-feature-parity-vonage-voice

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 27, 2026

  • Add tests for Connect NCCO class (0% → 100%)
  • Add tests for Notify NCCO class (0% → 100%)
  • Add tests for Record NCCO class (0% → 100%) including all setter validation
  • Add tests for Stream NCCO class (0% → 100%)
  • Expand Talk tests to cover optional constructor params and serialization (57% → 100%)
  • Expand Conversation tests to cover all constructor params and serialization (59% → 100%)
  • Expand Input tests to cover speech-only, eventMethod, mode, and error-throw paths (74% → 100%)
  • Add unmuteCall data set entry in update.ts (voice.ts line 607)
  • Fix pre-existing typo: style: '1'style: '0' in 'transfer call with NCCO' request mock
  • All 61 tests pass

@manchuck manchuck force-pushed the copilot/check-feature-parity-vonage-voice branch from 17953fe to e2ac3e5 Compare April 28, 2026 15:10
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 28, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
1114 2 1112 0
View the top 2 failed test(s) by shortest run time
Update call Can transfer call with NCCO
Stack Traces | 5s run time
Reflect.has called on non-object
Update call Can transfer call with NCCO
Stack Traces | 5s run time
Reflect.has called on non-object

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants