Repository navigation
fix: remove stale 128-tool limit - #291
Merged
Merged
Conversation
Vizards
marked this pull request as ready for review
October 7, 2026 04:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The obsolete guard and all related references are removed consistently while preserving tool conversion and preflight behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the obsolete 128-tool limit so larger Copilot Agent tool catalogs reach the DeepSeek API.
Changes:
- Advertises tool calling as an unlimited boolean capability.
- Removes local tool-count validation and its error messages.
- Updates English and Chinese guidance about large tool lists.
| File | Description |
|---|---|
src/types.ts |
Simplifies tool capability typing. |
src/provider/tools/request.ts |
Removes tool-count rejection. |
src/provider/tools/consts.ts |
Removes the obsolete limit constant. |
src/i18n.ts |
Removes obsolete localized errors. |
src/consts.ts |
Advertises tool calling for all models. |
resources/walkthrough/advanced-settings.md |
Updates English walkthrough guidance. |
resources/walkthrough/advanced-settings.nls.zh-cn.md |
Updates Chinese walkthrough guidance. |
README.md |
Removes stale English limit guidance. |
README.zh-cn.md |
Removes stale Chinese limit guidance. |
package.nls.json |
Updates English setting help. |
package.nls.zh-cn.json |
Updates Chinese setting help. |
docs/notices/tool-drift.en.md |
Removes stale English limit claims. |
docs/notices/tool-drift.zh.md |
Removes stale Chinese limit claims. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
WindSnowLi
added a commit
to WindSnowLi/multi-model-for-copilot
that referenced
this pull request
Oct 8, 2026
Align this fork with upstream v0.9.4 and with the VS Code 1.141 language model API:
- config: add `requestHeaders` with `${conversationId}` templating, merged
case-insensitively into every chat completion request (Vizards#266)
- models: add DeepSeek V4.1 Flash (native vision) and surface retirement notices
for the legacy V4 Flash entries through `warningText` and a status icon
(Vizards#267, Vizards#272)
- tools: emit an explicit empty schema for parameterless tools (Vizards#282) and drop
the stale 128-tool limit (Vizards#291)
- runtime: register the provider synchronously and refresh models after Copilot
activates, which avoids a BYOK activation deadlock (Vizards#275); stop refreshing
models during deactivation (Vizards#271)
- settings: add a `resetBaseUrl` command with scope preview, confirm API key
removal, link missing-key errors to the configuration flow, and contribute the
previously missing `qwenBaseUrl` setting (Vizards#276)
- vision: ship the improved Vision Proxy prompt as the default (Vizards#206)
- pricing: emit only `infoText`/`priceCategory` so the model picker stops
rendering formatted cost strings as "Unknown" (Vizards#241)
- provider: respect `toolMode: required` and declare `capabilities.apiType` as
Chat Completions
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #286
Problem
Copilot Agent Host sessions can pass more than 128 tool definitions to the provider. The extension rejects these requests locally before contacting DeepSeek, so Copilot retries the same failing request five times even though the official API accepts the tool catalog.
Changes and scope
Validation
npm run compile,npm run lint,npm run format:check, andgit diff --checkpassed.https://api.deepseek.comendpoint withdeepseek-flash(DeepSeek V4.1 Flash).limit_probe_150tool and returnedlimit_probe_150: TOOL_LIMIT_ROUNDTRIP_OKProvider metadata logs confirmed that all three successful API requests contained 249 tools. Temporary test fixtures, credentials, and logs are not included in this PR.
Final checks