Open
Conversation
make sure to delete the warning before committing to master or develop
… into gui-text-cleanup
These changes cause a link issue with language files when building and will need to be resolved. Oddly though the wallet still builds and has translations.
Sync with master
Sync with Develop
Contributor
|
Can you sumup or brief the changes you have made? is it just a find and replace or was more changes done? |
Contributor
Author
|
I edited the comment I made is that sufficiant |
akshaynexus
reviewed
Jan 6, 2020
|
|
||
| When you first run Electron Cash it will use a different configuration directory to Electrum. On Unix it is | ||
| ".electron-cash", and on Windows/MacOS it is "ElectronCash". Your wallet files will be copied from the Electrum | ||
| ".electron-cash", and on Windows/MacOS it is "Vilight". Your wallet files will be copied from the Electrum |
Contributor
There was a problem hiding this comment.
need to replace .electron-cash references with .vilight
Contributor
Author
There was a problem hiding this comment.
The file paths should be changed to follow system specific file paths. Such as macOS should be in ~/Library/Application Support/Vilight
akshaynexus
suggested changes
Jan 6, 2020
| <screenshots> | ||
| <screenshot type="default"> | ||
| <image type="source">https://www.electroncash.org/images/shot4.png</image> | ||
| <image type="source">https://www.https://www.vitaetoken.io//images/shot4.png</image> |
Contributor
Author
There was a problem hiding this comment.
See I knew I didn't get everything... I keep hunting things down.
Contributor
|
It doesn't use that type for dirs,uses .vilight for all oses
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vilightifying GUI, code and docs... Removes references to other altcoins within the code, gui and docs. Search and replace as well as changes by hand were made to avoid compiling issues. There may be some things that have been missed. There are a lot of changes...