Implement multirate simulations - take 3 #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Benchmark Results (Julia v1.10)Time benchmarks
Memory benchmarks
|
Contributor
Benchmark Results (Julia v1)Time benchmarks
Memory benchmarks
|
…ishing) into their own files
document new multi-rate option
for multi-rate policies
for multi-rate policy
VEZY
changed the title
VEZY
changed the title
We now make a window as large as the largest consumer request (e.g. one consumer at 4h and one at 24 will produce a 24h window) instead of the full history.
multirate with classic status tracking (Dict) vs multirate with online export requests (Vector{OutputRequest})
forbid using multithreading / distributed computing when in multirate mode
add more tests for multirate
… need to dev the pkg)
filter tests for when `ModelSpec` exists (not in Main)
This reverts commit b3a526d.
…urly meteo) + make a uniform interface with policies
…dow) or calendar (possibly using values future to the current step)
Add regular output print in multirate tutorial
Add test with all defaults for models running at different rates (testing inference of multirate traits)
Update PlantMeteo compat
Fix issues with versions (force using this PlantSimEngine)
This avoids to manually install XPalm and PlantSimEngine
Member
Author
|
Important: revert XPalm to main in the benchmark's Project before merging |
use only one version of julia
…ause the MTG may be partial)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to PlantSimEngine’s architecture, documentation, and core interfaces to support upcoming features like multi-rate simulation, scoped model instances, and advanced scheduling policies.
Documentation enhancements:
AI_PACKAGE_SUMMARY.md) explaining PlantSimEngine’s architecture, data structures, dependency graph, multiscale mapping, MTG integration, execution flow, and known pain points.Core scaffolding for multi-rate and scoped simulation:
src/PlantSimEngine.jlfor multi-rate scaffolding (time/multirate.jl) and model specification (mtg/ModelSpec.jl). [1] [2]GraphSimulation struct extension:
GraphSimulationstruct to includemodel_specsandtemporal_statefields, enabling support for normalized model usage specifications and multi-rate temporal storage.These changes collectively prepare PlantSimEngine for more flexible and robust simulation workflows, including multi-rate execution and scoped modeling.