Repository navigation
stoa-doctor: report faillock lockout, locked keyring, greeter auto-sync - #206
Merged
Merged
Conversation
Three failures that until now were silent: - pam_faillock counting failed logins: at `deny` of them sudo, polkit, the lock screen and greetd all refuse the right password together. - The login keyring locked, or another collection as default: Noctalia seals clipboard pins with a key from the default collection, so pins vanish at the next restart without an error. Also flags a greetd PAM stack missing pam_gnome_keyring. - [shell.greeter_sync] auto_sync = true in Noctalia's GUI state, which wins over config.toml and turns every wallpaper rotation into a polkit password prompt. enable-stoa-greetd.sh: correct the claim that clipboard state under the old default keyring was never persisted. On a real machine it held the user's pins; say where the backup is and which keyring holds its key. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MN4kDREFU6ZpG9wyDPKuhp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three auth-chain failures that were silent until now become doctor warnings:
faillock) againstdenyfrom/etc/security/faillock.conf(default 3). Locked → FAIL with the reset command; partial → WARN.~/.local/share/keyrings/defaultisn'tlogin, when thelogincollection reportsLocked = trueover the Secret Service, or when greetd is enabled but/etc/pam.d/greetddoesn't loadpam_gnome_keyring. Noctalia seals clipboard pins with a key from the default collection, so any of these makes pins disappear on restart.~/.local/state/noctalia/settings.toml(TOML, so a table or an inline value both work) forshell.greeter_sync.auto_sync = true. That GUI state overridesconfig.toml'sfalse, and every wallpaper rotation then shows a pkexec/polkit password prompt. A real machine logged one every ~27 min withinterval_seconds = 1800.enable-stoa-greetd.sh: fixes the comment that said clipboard state under the old default keyring had never been saved. On the machine above, that state held the user's pins (a 2 KBindex.encplus entries). The script still moves the state aside, but now prints where the backup is and which keyring holds its key.bash tests/run.sh: 14 passed, 3 skipped. I checked the TOML and faillock parsing against sample input.Generated by Claude Code