Repository navigation
aur: retry a failed AUR build once; don't abort post-install on one app - #204
Merged
Merged
Conversation
yay builds dependencies first; when one fails transiently (libpdfium-nojs hit a broken download in prepare()), yay retries the dependency but drops the package that needs it (yacreader: "Missing dependencies"). Under set -e that aborted the whole post-install. _install_aur now retries once and returns 1 (recording the pkg in _aur_failed) if both attempts fail. post-install tolerates failures of its optional AUR apps and lists them at the end; enable-limine-snapshots still aborts, since it needs its packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012pNTgiWNwQg9cE63aUxicE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
post-install.shfailed on YACReader. yay builds dependencies first. Whenlibpdfium-nojshit a transient download error inprepare()(curl: (23)/base64: invalid input), yay retried that dependency and installed it, but it had already droppedyacreaderwith "Missing dependencies". The yay failure also stopped the whole script, because it runs withset -e.Changes
setup/lib/aur.sh:_install_aurretries the build once. If both attempts fail, it prints a warning, adds the package to_aur_failedand returns 1. Before this change it printed[✓] installedno matter what happened, and the makepkg fallback ignored clone and build errors.setup/post-install.sh: a failure in one optional AUR app no longer stops the script (|| true). Failed packages are listed with ayay -S …retry hint at the end of the AUR step.enable-limine-snapshots.shstill aborts when its required AUR packages fail.Testing
bash -non both scripts.set -ewith a fakeyaythat fails once and then succeeds: the retry succeeds. With one that always fails: post-install continues, while the strict call site exits with status 1.Generated by Claude Code