feat(browser): support custom Chrome flags via VIBIUM_CHROME_ARGS#178
Open
youdie006 wants to merge 1 commit into
Open
feat(browser): support custom Chrome flags via VIBIUM_CHROME_ARGS#178youdie006 wants to merge 1 commit into
youdie006 wants to merge 1 commit into
Conversation
chromeArgs built a fixed flag list, so there was no way to pass extra Chrome flags (e.g. --no-sandbox) needed to run as root in CI/container environments. Read VIBIUM_CHROME_ARGS (space-separated, empty tokens skipped) and append the flags to goog:chromeOptions, with no client-SDK changes. Closes VibiumDev#141
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chromeArgsbuilt a fixed flag list, so there was no way to pass extra Chrome flags (e.g.--no-sandbox) needed to run as root in CI/container environments (#141, option 1 from the issue).Fix
clicker/internal/browser/launcher.go: readVIBIUM_CHROME_ARGS(space-separated, empty tokens skipped) and append the flags togoog:chromeOptions, with no client-SDK changes — so it works across all language clients. Added launcher tests covering the set / unset / whitespace-padded env cases.Closes #141