Skip to content

[VPI-331] - Use DNS suffix in token exchange guide examples - #117

Merged
MadisonEhlers-Vertex merged 1 commit into
mainfrom
VPI-331-private-cloud-urls
Sep 30, 2026
Merged

MadisonEhlers-Vertex merged 1 commit into
mainfrom
VPI-331-private-cloud-urls

Conversation

@MadisonEhlers-Vertex

@MadisonEhlers-Vertex MadisonEhlers-Vertex commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor
Author Host When
Agent:(claude-opus-5.5) Cursor on madisonehlers' macOS machine 2026-09-30 5:08 PM CDT

Summary

Follow-up to #116 for the token exchange OIDC configuration guide:

  • Removes the note about allowing http:// endpoints with ALLOW_HTTP_OIDC_ENDPOINTS.
    That's an internal development setting, not something customers configure.
  • Changes the Platform API examples from platform.vertexvis.com to
    platform.[DNS_SUFFIX], with a short explanation, so they also work for
    private cloud deployments.

Test Plan

  • docusaurus build and Prettier pass.

Release Notes

None.

Possible Regressions

None. Docs only.

Dependencies

None.

Related

VPI-331 · #116


Note

Low Risk
Documentation-only edits with no runtime or API behavior changes.

Overview
Updates the token exchange OIDC configuration guide so examples work for private cloud and other non–vertexvis.com deployments.

Endpoint requirements: Drops the customer-facing bullet about requiring https:// and the internal ALLOW_HTTP_OIDC_ENDPOINTS override.

API examples: Replaces hard-coded https://platform.vertexvis.com URLs with https://platform.[DNS_SUFFIX] and adds a short note explaining how to substitute your deployment’s DNS suffix (e.g. dev.example.com → https://platform.dev.example.com) for token, account create/update, and account GET curls.

Reviewed by Cursor Bugbot for commit 553b38a. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: Cursor <cursoragent@cursor.com>
@MadisonEhlers-Vertex
MadisonEhlers-Vertex requested a review from a team as a code owner September 30, 2026 22:10
@sonarqubecloud

Copy link
Copy Markdown

@MadisonEhlers-Vertex
MadisonEhlers-Vertex enabled auto-merge (squash) September 30, 2026 22:11
@MadisonEhlers-Vertex
MadisonEhlers-Vertex merged commit e7c8a39 into main Sep 30, 2026
4 checks passed
@MadisonEhlers-Vertex
MadisonEhlers-Vertex deleted the VPI-331-private-cloud-urls branch September 30, 2026 22:12

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 553b38a. Configure here.


The examples in this guide use `platform.[DNS_SUFFIX]`, where `[DNS_SUFFIX]` is
your deployment's DNS suffix. For example, if your DNS suffix is
`dev.example.com`, the Platform API is at `https://platform.dev.example.com`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing private-cloud-only callout

Medium Severity

The platform.[DNS_SUFFIX] examples treat the deployment DNS suffix as a general setting without a private-cloud-only callout or the public cloud host vertexvis.com. Public Vertex cloud customers cannot configure a DNS suffix and may not know which API host to use.

Fix in Cursor Fix in Web

Triggered by learned rule: Call out private-cloud-only features

Reviewed by Cursor Bugbot for commit 553b38a. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants