Repository navigation
[PLAT-9044] Clean-up examples - #114
Conversation
|
jdm717
left a comment
jdm717
left a comment
There was a problem hiding this comment.
LGTM! Just had one question
| VERTEX_CLIENT_ID= | ||
| VERTEX_CLIENT_SECRET= | ||
| VERTEX_TOKEN= | ||
| VERTEX_FILE_ID= |
There was a problem hiding this comment.
Curious here - will these be injected somehow such that the helpers.js file will be able to access them in a deployed environment? Or will this only work locally after this change?
Don't think it's too critical either way given this example is only exposed in the beta documentation branch (probably a question of whether we should still have those at this point honestly), just curious!
There was a problem hiding this comment.
We discussed separately and are okay merging this change as these examples are not really used.
2 participants
Summary
We no longer expose a '/demo_config' endpoint, so the examples were not working and were resulting in warnings in our logs. This PR updates the examples to use environment variables.
Test Plan
Verify the examples can be run and warnings no longer appears in our logs
Release Notes
Clean-up examples
Possible Regressions
Examples
Dependencies
None