Repository navigation
fix: accept .soothfast/* as the init ignore line - #409
Merged
Merged
Conversation
Contributor
soothfast gatesoothfast-site |
Contributor
soothfast gatesoothfast-report |
Contributor
soothfast gatesoothfast-measure |
Contributor
soothfast gatesoothfast-registry |
Contributor
soothfast gatesoothfast-docs |
Contributor
soothfast gatesoothfast-sdk |
Contributor
soothfast gatesoothfast-spec |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
cargo soothfast inittreats a.gitignorethat has.soothfast/*as already ignoring the directory. Before, it only recognised the directory forms (.soothfast,.soothfast/, with or without a leading slash) and appended.soothfast/to a file that had the contents form./*insame_ignorebefore comparing the two lines.any_root_form_of_the_ignore_line_counts_as_presentwith.soothfast/*and/.soothfast/*.Why
A repository that tracks one file under
.soothfast/ignores the directory with.soothfast/*and a!exception for that file. The appended.soothfast/line overrides the exception, because git cannot un-ignore a file inside an ignored directory.git addof the tracked file is then refused, which failed a landing step that names it.init --checkalso reported the file as drifted until the harmful line was put back.How was this tested
cargo test -p cargo-soothfast any_root_form: 1 passed, 0 failed.cargo clippy -p cargo-soothfast --all-targets -- -D warnings: clean.make checkandmake gatewere not run.Checklist
make checkpasses (fmt, clippy-D warnings,cargo test --workspace)make gate BASE=masterpasses, or any intentional cost change is explained above///doc commentsREADME.md,docs/,soothfast:bind/soothfast:claimmarkers) updated if behavior changed