Feat/delta simplify cancel and withdraw#235
Open
andriy-shymkiv wants to merge 3 commits intomasterfrom
Open
Conversation
size-limit report 📦
|
…plify-cancelAndWithdraw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified
cancelAndWithdrawfollowing the changes on the contracts sidecloses FRNT-1310
Note
Medium Risk
Medium risk because it’s a breaking API/ABI change that alters how on-chain
cancelAndWithdrawis encoded; mismatches with deployed contract versions or downstream callers will cause transaction failures or compile-time breaks.Overview
Updates Delta
cancelAndWithdrawto match the latest contract interface by removing signature/cosignature/bridgeOverride handling and passing a sanitizedOrderstruct directly.This changes the
DeltaTokenModuleAbidefinition and thecancelAndWithdrawDeltaOrderAPI (drops thesignatureparam), eliminating the previousOrderWithSigwrapper and default bridge override logic.Reviewed by Cursor Bugbot for commit 33d1e3f. Bugbot is set up for automated code reviews on this repo. Configure here.