Repository navigation
Add parser regression tests for candidate selection - #35
Merged
Merged
Conversation
rk042
marked this pull request as draft
November 14, 2026 03:54
Owner
|
Thanks @rk042, looks good to me. CI is red because the 8 new tests need the parser change that isn't on main yet. I'll push that first, then update this branch so CI re-runs, then merge. No changes needed from you. |
Owner
|
Thanks, @rk042! I've updated my branch on my end. It should be good to pull in the latest upstream changes and push the updates again. |
Contributor
Author
|
Thanks! I merged the latest upstream changes into my branch. The parser regression tests now pass: 21 passed. The full suite reports 436 passed and 6 skipped, and mypy is clean. |
rk042
marked this pull request as ready for review
November 14, 2026 05:11
Owner
|
@rk042 LGTM! I'll merge this PR. I'll make a few minor tweaks to the documentation and possibly some code adjustments, then aim to release v0.5.9 on PyPI tomorrow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds regression tests for JSON candidate ordering, top-level and nested objects, fallback behavior, retries, and sync/async consistency.
Related to #33.
Why?
The tests capture the behavior discussed for the planned v0.5.9 parser changes. In particular, nested objects should not be selected as answers, and an invalid outer answer should produce a parse failure rather than falling back to a nested object.
Checklist
This is a tests-only PR. The maintainer is preparing the parser implementation and changelog entry separately.
Anything else worth knowing?
Against the current BOOTH 0.5.8 code, the new test file reports 13 passed and 8 failed. The failures are expected until the parser changes are available. I’ll rerun the tests and full suite after integrating the implementation.