Skip to content

[DNC] - Step Dance to Last Dance Combo #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VariableVixen merged 1 commit into from
Jan 7, 2026
Merged

[DNC] - Step Dance to Last Dance Combo #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion XIVComboVX/Combos/DNC.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ public const byte
SaberDance = 76, // [sic] - should be Sabre but america
Tillana = 82,
FanDance4 = 86,
StarfallDance = 90;
StarfallDance = 90,
LastDance = 92;

}
}
Expand Down Expand Up @@ -357,6 +358,19 @@ protected override uint Invoke(uint actionID, uint lastComboMove, float comboTim
}
}

internal class LastDanceFeature: DancerCombo {
public override CustomComboPreset Preset { get; } = CustomComboPreset.LastDanceFeature;
public override uint[] ActionIDs { get; } = [DNC.StandardStep];

protected override uint Invoke(uint actionID, uint lastComboMove, float comboTime, byte level) {

if (level >= DNC.Levels.LastDance && SelfHasEffect(DNC.Buffs.LastDanceReady))
return DNC.LastDance;

return actionID;
}
}

internal class DancerDevilmentFeature: DancerCombo {
public override CustomComboPreset Preset { get; } = CustomComboPreset.DancerDevilmentFeature;
public override uint[] ActionIDs { get; } = [DNC.Devilment];
Expand Down
3 changes: 3 additions & 0 deletions XIVComboVX/CustomComboPreset.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,9 @@ public enum CustomComboPreset {
[CustomComboInfo("Smart Dance", "Change your normal ST/AOE combos into the next dance steps (and then the finishers) while dancing.", DNC.JobID)]
DancerSmartDanceFeature = 38014,

[CustomComboInfo("Last Dance Feature", "Change Standard Step into Last Dance when Last Dance Ready is active.", DNC.JobID)]
LastDanceFeature = 38026,

[CustomComboInfo("Devilment Feature", "Change Devilment into Starfall Dance after use.", DNC.JobID)]
DancerDevilmentFeature = 38007,

Expand Down